Daniel Martí
98d4b0de6e
pool: error quickly if we find a port in use
...
Before the fix, the added test would give a Pool.Allocate error like:
pool could not connect to 9000: timeout waiting for initial target
The actual underlying error, which can only be seen if one inspects
chrome's stderr, is that it failed to bind to the debugging protocol
port if it was already in use.
This is of course an issue with the environment that chromedp is being
run under, since it was given a port range that wasn't available.
However, the confusing error can lead to developers wasting their time
instead of spotting the error quickly.
Unfortunately, there doesn't seem to be a way to have Chrome exit
immediately if it can't bind to the given port. So, instead of relying
on it, check if the current process can bind to the port first.
Add a test too, where we grab the first port in the pool range, and
check that we get an error that's not confusing.
Fixes #253 .
2018-12-01 11:54:16 +00:00
Kenneth Shaw
bf52fed0d3
Fixing windows build issue
2018-07-18 06:19:22 +07:00
Kenneth Shaw
34591780d9
Updating dependencies
2018-07-13 12:49:42 +07:00
Kenneth Shaw
53015e7d81
Changing Debugging => DevTools
2018-07-13 12:46:30 +07:00
Kenneth Shaw
74e379587b
Minor code cleanup to client package before rewrite
2018-07-13 11:35:03 +07:00
Kenneth Shaw
4ae10864e4
Adding client API changes prior to package rewrite
2018-07-13 11:24:37 +07:00
Kenneth Shaw
d413f67302
Minor cleanup to client/gen.go
2018-07-13 11:00:35 +07:00
Kenneth Shaw
622c90c82c
Cleaning up runner API prior to package rewrite
2018-07-13 10:57:20 +07:00
Kenneth Shaw
e051c4a982
Removing errors dependency in client and runner packages
2018-07-13 09:28:45 +07:00
Kenneth Shaw
0406fa8a8a
Fixing issue with kb
2018-07-10 19:51:58 +07:00
Kenneth Shaw
db9a873141
Updating dependencies
2018-07-04 05:23:33 +07:00
Kenneth Shaw
68c34da207
Initial vgo support
2018-05-26 14:05:58 +07:00
ljun20160606
e57a331e5c
fix: windows tempfile path in %USERPROFILE%\AppData\Local
...
#13
2018-05-23 15:53:19 +08:00
Kenneth Shaw
5bf6a0e59d
Additional With* options for calls to chromedp.New()
2018-05-19 10:17:19 +07:00
Kenneth Shaw
b389c03ae7
Adding workaround for non-localhost client connections
2018-05-19 10:16:23 +07:00
Kenneth Shaw
1e1a3ace12
General code cleanup
2018-05-19 05:06:19 +07:00
Kenneth Shaw
310d213f6f
Fixing path in kb/gen.go
2018-05-07 14:11:23 +07:00
Kenneth Shaw
f683cfc4c1
Minor code cleanup
2018-03-27 04:31:09 +07:00
Kenneth Shaw
117d42c3dd
Minor change to client (supporting 1.3)
2018-03-20 19:07:54 +07:00
Kenneth Shaw
097f1903e5
Bumping travis-ci config to go1.10.x series
2018-03-02 09:02:06 +07:00
Kenneth Shaw
54f529fc51
Changing chromedp-gen => cdproto-gen
2018-02-16 07:23:02 +07:00
Kenneth Shaw
46a6388474
Fixing broken links in README.md
2017-12-28 11:38:11 +07:00
Kenneth Shaw
b0c2445e67
Splitting repositories
2017-12-28 11:17:14 +07:00
Kenneth Shaw
9424dc57d6
Removing empty doc.go file
2017-12-22 10:14:21 +07:00
Kenneth Shaw
0faecc62db
Updating to latest protocol.json
2017-12-22 10:07:54 +07:00
Kenneth Shaw
69e069d131
Fixing issue with missing target_type values in client package
2017-12-22 10:01:21 +07:00
Kenneth Shaw
dd8119a9c5
Updating eval example
2017-12-22 09:01:51 +07:00
Kenneth Shaw
f9f17190d9
Removing edge-simple example
2017-12-22 09:00:50 +07:00
Kenneth Shaw
514f86f131
Minor change to documentation on runner.DefaultChromePath consts
2017-12-22 08:43:51 +07:00
Kenneth Shaw
dde782082b
Minor documentation change to CaptureScreenshot
2017-12-19 12:14:35 +07:00
Kenneth Shaw
6d2e39b47b
Minor change to chromedp-proxy to remove non-identifier characters in log names
2017-12-19 11:24:22 +07:00
Kenneth Shaw
6afa874714
Add empty *page.EventLifecycleEvent handler
...
Fixes #154
2017-12-18 11:03:22 +07:00
Daniel Martí
335d22d376
all: simplify some error variables
...
There's no need to put the error variables in a larger scope, nor define
them earlier than necessary. If anything, it makes the code harder to
follow, such as figuring out when nil errors are returned.
2017-12-18 10:51:37 +07:00
Daniel Martí
7ed029cf24
all: remove unnecessary loop labels
...
All of them are used for a single return, so use the return instead.
2017-12-18 10:51:37 +07:00
Daniel Martí
a9647b3e5b
all: make vet happy on non-generated code
2017-12-18 10:51:37 +07:00
Daniel Martí
98b0b39779
CI: use latest versions of each Go major version
...
And use -u on go get.
2017-12-18 10:51:37 +07:00
Kenneth Shaw
380c95b6c0
Minor documentation cleanup from last commit
2017-12-18 10:48:40 +07:00
kotamat
07208b1cc3
Add Atributes All feature
2017-12-18 10:42:13 +07:00
kotamat
8f3b889b9f
add test code for query
...
it will be through the coverage test
2017-12-18 10:39:44 +07:00
Kenneth Shaw
2f3b8c00e9
Fixing issue with unit tests so that they run properly on Darwin/Windows
2017-12-18 09:55:04 +07:00
Kenneth Shaw
149612cd65
Updating to latest protocol.json
2017-12-18 07:23:14 +07:00
Kenneth Shaw
148e24a615
Fixing issues with unit tests
...
1. Changes travis configuration to use the chrome addon
2. Adds more command line options to runner package
3. Removes grab-headless_shell.sh script
4. Cleans up and adds some environment variables for controlling how
unit tests are ran
5. Fixes a minor issue in chromedp-gen on comment output (for working
with latest protocol definition)
2017-12-18 07:11:42 +07:00
Kenneth Shaw
fd310a9b84
Centralizing comment / description cleanup in chromedp-gen
2017-12-01 11:00:44 +07:00
Kenneth Shaw
df58ab5964
Updating to latest protocol.json
2017-11-28 09:41:21 +07:00
Kenneth Shaw
4f13da10e7
Fixing issue from last protocol definition update
2017-11-22 16:02:51 +07:00
Kenneth Shaw
88d4832728
Updating to latest protocol.json
2017-11-22 12:01:27 +07:00
Kenneth Shaw
289f0eeb04
Updating to latest protocol.json
2017-11-02 11:49:15 +07:00
Kenneth Shaw
89723e0ce3
Updating to latest protocol.json
2017-10-24 09:06:01 +07:00
Kenneth Shaw
60dbb97d45
Updating to latest protocol.json
2017-10-18 09:26:49 +07:00
Kenneth Shaw
49117a03d8
Updating to latest protocol.json
2017-10-15 12:47:06 +07:00
