Commit Graph

17 Commits

Author SHA1 Message Date
Kenneth Shaw
6afa874714 Add empty *page.EventLifecycleEvent handler
Fixes #154
2017-12-18 11:03:22 +07:00
Daniel Martí
335d22d376 all: simplify some error variables
There's no need to put the error variables in a larger scope, nor define
them earlier than necessary. If anything, it makes the code harder to
follow, such as figuring out when nil errors are returned.
2017-12-18 10:51:37 +07:00
Daniel Martí
7ed029cf24 all: remove unnecessary loop labels
All of them are used for a single return, so use the return instead.
2017-12-18 10:51:37 +07:00
Rob Holland
68bf958ce3 If we receive an updated frame ensure we reset cur if required.
Prior to this change `cur` can be stale, meaning the frame returned for
`WaitFrame(ctxt, cdptypes.EmptyFrameID)` will be out of date, and never updated
based on incoming events.
2017-06-18 08:10:24 +07:00
Kenneth Shaw
622bb2ac33 Removing bad context declaration 2017-06-18 08:07:06 +07:00
Kenneth Shaw
869aafc836 Adding script to generate domains from protocol.json and updating to latest protocol.json 2017-05-06 08:20:24 +07:00
Kenneth Shaw
eb9de08765 Fixing typo from last commit 2017-03-28 07:42:47 +07:00
Kenneth Shaw
8eb44961e2 Adding simple bounds check on InlineStyleInvalidated events
Temporary fix. Better logic should be in place to handle this.

Fixes #44
2017-03-28 06:59:28 +07:00
Kenneth Shaw
4c16faa34d Minor code cleanup/maintenance on generated cdp protocol 2017-02-18 15:36:24 +07:00
Kenneth Shaw
ab80f4c5bc Fixing race issues on nodes 2017-02-18 14:28:43 +07:00
Randy Cahyana
0db7a9ee72 Increasing unit test coverage on query.go 2017-02-18 10:50:33 +07:00
Kenneth Shaw
b5032069e3 Fixing race issues
- Refactored chromedp-gen and cdp code so that Execute no longer returns
  a channel
- Fixing potential race problems in handler
- Eliminated some dead code
- Updated examples to include new logging parameters
2017-02-14 17:15:53 +07:00
Kenneth Shaw
7326b390a0 Initial changes to provide configurable logging options 2017-02-13 16:00:39 +07:00
Kenneth Shaw
3673164aef Code cleanup
- Refactored API calls to be cleaner
- Changed types that shoudn't be exported to not-exported
- Updated examples with API changes
- Added unit test for Title action
2017-02-12 14:08:40 +07:00
Kenneth Shaw
f73c429109 Renaming FrameHandler, updating to latest protocol.json, and code fixes 2017-02-12 12:50:46 +07:00
Kenneth Shaw
58283934b9 Fixing issues with code generation 2017-01-26 14:28:34 +07:00
Kenneth Shaw
20d575fece Initial import 2017-01-24 22:09:23 +07:00