commons_go/chromedp
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

don't run TestFileUpload subtests in parallel

Browse Source 
Turns out that these subtests are the only pair which cannot run in
parallel with each other. Undo that change and add a TODO. This should
fix the CI failures.

While at it, remove an unnecessary testAllocate line.
This commit is contained in:
Daniel Martí 2019-02-21 17:22:40 +01:00
parent 4c16288502
commit 811d6d54d3
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
query_test.go
View File

@ -964,9 +964,6 @@ func TestFileUpload(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
c := testAllocate(t, "")
defer c.Release()
tests := []struct { tests := []struct {
a Action a Action
}{ }{
@ -976,7 +973,9 @@ func TestFileUpload(t *testing.T) {
for i, test := range tests { for i, test := range tests {
t.Run(fmt.Sprintf("test %d", i), func(t *testing.T) { t.Run(fmt.Sprintf("test %d", i), func(t *testing.T) {
t.Parallel() // TODO: refactor the test so the subtests can run in
// parallel
//t.Parallel()
c := testAllocate(t, "") c := testAllocate(t, "")
defer c.Release() defer c.Release()