From 811d6d54d3cd7560ad7f77454cc5ad332903bde8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Thu, 21 Feb 2019 17:22:40 +0100 Subject: [PATCH] don't run TestFileUpload subtests in parallel Turns out that these subtests are the only pair which cannot run in parallel with each other. Undo that change and add a TODO. This should fix the CI failures. While at it, remove an unnecessary testAllocate line. --- query_test.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/query_test.go b/query_test.go index 7e4af11..f681c4c 100644 --- a/query_test.go +++ b/query_test.go @@ -964,9 +964,6 @@ func TestFileUpload(t *testing.T) { t.Fatal(err) } - c := testAllocate(t, "") - defer c.Release() - tests := []struct { a Action }{ @@ -976,7 +973,9 @@ func TestFileUpload(t *testing.T) { for i, test := range tests { t.Run(fmt.Sprintf("test %d", i), func(t *testing.T) { - t.Parallel() + // TODO: refactor the test so the subtests can run in + // parallel + //t.Parallel() c := testAllocate(t, "") defer c.Release()