From a8a49309566236cf8913c89cfd24f079fb4a1b54 Mon Sep 17 00:00:00 2001
From: leejinho <lilis7575@gmail.com>
Date: Tue, 28 Jan 2020 09:35:23 +0900
Subject: [PATCH] =?UTF-8?q?=EB=A1=9C=EA=B7=B8=EC=9D=B8=20=ED=8E=98?=
 =?UTF-8?q?=EC=9D=B4=EC=A7=80=20validation=20=EC=97=90=EB=9F=AC=20?=
 =?UTF-8?q?=EB=A9=94=EC=8B=9C=EC=A7=80=20=ED=91=9C=EC=B6=9C=EB=B0=A9?=
 =?UTF-8?q?=EC=8B=9D=20=EC=88=98=EC=A0=95.=20>>=20=ED=95=98=EB=8B=A8?=
 =?UTF-8?q?=EC=97=90=20=ED=95=9C=EB=B2=88=EC=97=90=20=EC=B6=9C=EB=A0=A5?=
 =?UTF-8?q?=ED=95=98=EB=8A=94=20=EB=B0=A9=EC=8B=9D=EC=9C=BC=EB=A1=9C=20?=
 =?UTF-8?q?=EC=88=98=EC=A0=95.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../src/lib/components/login.component.html   | 43 ++++++++++++++-----
 .../src/lib/components/login.component.ts     | 37 +++++++++++-----
 2 files changed, 58 insertions(+), 22 deletions(-)

diff --git a/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.html b/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.html
index 19fac539..2c66bb40 100644
--- a/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.html
+++ b/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.html
@@ -9,33 +9,54 @@
   <form name="loginForm" [formGroup]="loginForm" novalidate>
     <mat-form-field [style.display]="!!curCompanyCode ? 'none' : 'block'">
       <mat-label>{{ 'accounts.fieldCompany' | translate }}</mat-label>
-      <mat-select formControlName="companyCode" required>
+      <mat-select [formControl]="companyCodeFormControl">
         <mat-option
           *ngFor="let company of companyList"
           [value]="company.companyCode"
           >{{ company.companyName }}
         </mat-option>
       </mat-select>
-      <mat-error *ngIf="loginForm.get('companyCode').hasError('required')">
-        {{ 'accounts.errors.requireCompany' | translate }}
-      </mat-error>
     </mat-form-field>
 
     <mat-form-field>
       <mat-label>{{ 'accounts.fieldLoginId' | translate }}</mat-label>
-      <input matInput formControlName="loginId" />
-      <mat-error *ngIf="loginForm.get('loginId').hasError('required')">
-        {{ 'accounts.errors.requireLoginId' | translate }}
-      </mat-error>
+      <input matInput [formControl]="loginIdFormControl" />
     </mat-form-field>
 
     <mat-form-field>
       <mat-label>{{ 'accounts.fieldLoginPw' | translate }}</mat-label>
-      <input matInput type="password" formControlName="loginPw" #loginPw />
-      <mat-error>
+      <input
+        matInput
+        type="password"
+        [formControl]="loginPwFormControl"
+        #loginPw
+      />
+    </mat-form-field>
+
+    <div class="error-container">
+      <mat-error
+        *ngIf="
+          companyCodeFormControl.dirty &&
+          companyCodeFormControl.hasError('required')
+        "
+      >
+        {{ 'accounts.errors.requireCompany' | translate }}
+      </mat-error>
+      <mat-error
+        *ngIf="
+          loginIdFormControl.dirty && loginIdFormControl.hasError('required')
+        "
+      >
+        {{ 'accounts.errors.requireLoginId' | translate }}
+      </mat-error>
+      <mat-error
+        *ngIf="
+          loginPwFormControl.dirty && loginPwFormControl.hasError('required')
+        "
+      >
         {{ 'accounts.errors.requireLoginPw' | translate }}
       </mat-error>
-    </mat-form-field>
+    </div>
 
     <button
       mat-raised-button
diff --git a/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.ts b/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.ts
index f421adec..b5f8e321 100644
--- a/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.ts
+++ b/projects/ucap-webmessenger-ui-account/src/lib/components/login.component.ts
@@ -8,7 +8,13 @@ import {
   ElementRef,
   ChangeDetectorRef
 } from '@angular/core';
-import { FormGroup, FormBuilder, Validators } from '@angular/forms';
+import {
+  FormGroup,
+  FormBuilder,
+  Validators,
+  FormControl,
+  ValidatorFn
+} from '@angular/forms';
 import { Company } from '@ucap-webmessenger/api-external';
 
 @Component({
@@ -57,6 +63,9 @@ export class LoginComponent implements OnInit {
   @ViewChild('loginPw', { static: true }) loginPwElementRef: ElementRef;
 
   loginForm: FormGroup;
+  companyCodeFormControl = new FormControl('');
+  loginIdFormControl = new FormControl('');
+  loginPwFormControl = new FormControl('');
 
   constructor(
     private formBuilder: FormBuilder,
@@ -64,10 +73,23 @@ export class LoginComponent implements OnInit {
   ) {}
 
   ngOnInit() {
+    const companyCodeValidators: ValidatorFn[] = [Validators.required];
+    this.companyCodeFormControl.setValidators(companyCodeValidators);
+    if (!!this.curCompanyCode) {
+      this.companyCodeFormControl.setValue(this.curCompanyCode);
+    }
+    const loginIdValidators: ValidatorFn[] = [Validators.required];
+    this.loginIdFormControl.setValidators(loginIdValidators);
+    if (!!this.loginId) {
+      this.loginIdFormControl.setValue(this.loginId);
+    }
+    const loginPwValidators: ValidatorFn[] = [Validators.required];
+    this.loginPwFormControl.setValidators(loginPwValidators);
+
     this.loginForm = this.formBuilder.group({
-      companyCode: ['', [Validators.required]],
-      loginId: ['', [Validators.required]],
-      loginPw: ['', Validators.required],
+      companyCodeFormControl: this.companyCodeFormControl,
+      loginIdFormControl: this.loginIdFormControl,
+      loginPwFormControl: this.loginPwFormControl,
       rememberMe: [false],
       autoLogin: [false]
     });
@@ -80,13 +102,6 @@ export class LoginComponent implements OnInit {
       this.loginForm.get('autoLogin').setValue(true);
     }
 
-    if (!!this.curCompanyCode) {
-      this.loginForm.get('companyCode').setValue(this.curCompanyCode);
-    }
-    if (!!this.loginId) {
-      this.loginForm.get('loginId').setValue(this.loginId);
-    }
-
     if (!this.loginBtnText || this.loginBtnText.trim().length === 0) {
       this.loginBtnText = 'LOGIN';
     }