Commit Graph

6 Commits

Author SHA1 Message Date
Jim Schubert
d8c9f25b10 Update sonar.yml
Limit next-version release branches to those ending in `.x`
2020-01-26 11:36:11 -05:00
Jim Schubert
c9ec084418 🐛 Fixing some issues with threading and NPE (#5107)
* 🐛 Fixing some issues with threading and NPE

After running Sonar on the master branch, some major analysis
opportunities were displayed.

This fixes the use of SimpleDateFormat stored as static fields.
SimpleDateFormat is not thread-safe, and may retain data across threads.
While there's no indicator that this has caused any issues (these are
mostly used for example code), we should follow these best practices.

This also fixes a handful of NPE and other minor issues such as
comparing Boolean.TRUE to strings and no wrapping some closeables in
try-with-resources.

* [cli] Unit test GenerateBatch custom deserialization helper

* Quiet batch mode in sonar.yml

* Suppress unnecessary warnings (ThreadLocals in static fields)
2020-01-25 18:28:16 -05:00
Jim Schubert
ad4a9df328 Update sonar.yml
Set GITHUB_REF with replacement to remove refs/heads prefix
2020-01-24 22:37:27 -05:00
Jim Schubert
9928f3c375 Update sonar.yml 2020-01-24 22:25:58 -05:00
Jim Schubert
43b6272fc6 Update sonar.yml 2020-01-24 22:18:13 -05:00
Jim Schubert
5220d7cd59 Create sonar.yml 2020-01-24 22:13:08 -05:00