From fa09d75180e673041aa2cc1ef11c729576be271b Mon Sep 17 00:00:00 2001 From: erdarun Date: Tue, 25 Apr 2017 18:45:39 +0530 Subject: [PATCH] Fix NullPointerException for info.version on Javascript client codegen (#5471) * Fix NullPointerException for info.version on Javascript client codegen * Set/Return project default version to 1.0.0 if info.version not found * info version null check handled and default version/appVersion value set to 1.0.0 * Removed null check for info version. Fixed DefaultGenerator code to handle null check. * Semicolon added missing --- .../src/main/java/io/swagger/codegen/DefaultGenerator.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultGenerator.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultGenerator.java index d59f67a4096d..55d90b85c35e 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultGenerator.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultGenerator.java @@ -151,6 +151,9 @@ public class DefaultGenerator extends AbstractGenerator implements Generator { } if (info.getVersion() != null) { config.additionalProperties().put("appVersion", config.escapeText(info.getVersion())); + } else { + LOGGER.error("Missing required field info version. Default appVersion set to 1.0.0"); + config.additionalProperties().put("appVersion", "1.0.0"); } if (StringUtils.isEmpty(info.getDescription())) { // set a default description if none if provided @@ -180,6 +183,9 @@ public class DefaultGenerator extends AbstractGenerator implements Generator { } if (info.getVersion() != null) { config.additionalProperties().put("version", config.escapeText(info.getVersion())); + } else { + LOGGER.error("Missing required field info version. Default version set to 1.0.0"); + config.additionalProperties().put("version", "1.0.0"); } if (info.getTermsOfService() != null) { config.additionalProperties().put("termsOfService", config.escapeText(info.getTermsOfService()));