loafle/openapi-generator
3
0
Fork 0
forked from loafle/openapi-generator-original
Code Pull Requests Activity

[JAVA][FEIGN] Removing hardcoded HTTP Client which is causing performance issues (#21085)

Browse Source 
* [JAVA][FEIGN] Removing hardcoded HTTP Client

Fixing performance issues

* Updating samples for Java Feign performance betterment changes

* added APIClient.java for feign-hc5
This commit is contained in:
Sri Sushma Karra 2025-04-17 17:13:07 +08:00 committed by GitHub
parent 5e446b4147
commit f9f5af5ed9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/openapi-generator/src/main/resources/Java/libraries/feign/ApiClient.mustache vendored
View File

@ -9,12 +9,6 @@ import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
{{#jackson}} {{#jackson}}
{{#feign-okhttp}}
import feign.okhttp.OkHttpClient;
{{/feign-okhttp}}
{{#feign-hc5}}
import feign.hc5.ApacheHttp5Client;
{{/feign-hc5}}
import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature; import com.fasterxml.jackson.databind.SerializationFeature;
@ -76,12 +70,6 @@ public class ApiClient {
{{#jackson}} {{#jackson}}
objectMapper = createObjectMapper(); objectMapper = createObjectMapper();
feignBuilder = Feign.builder() feignBuilder = Feign.builder()
{{#feign-okhttp}}
.client(new OkHttpClient())
{{/feign-okhttp}}
{{#feign-hc5}}
.client(new ApacheHttp5Client())
{{/feign-hc5}}
.encoder(new FormEncoder(new JacksonEncoder(objectMapper))) .encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper)) .decoder(new ApiResponseDecoder(objectMapper))
{{#hasOAuthMethods}} {{#hasOAuthMethods}}

2
samples/client/petstore/java/feign-hc5/src/main/java/org/openapitools/client/ApiClient.java
View File

@ -19,7 +19,6 @@ import java.util.function.Supplier;
import java.util.logging.Level; import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
import feign.hc5.ApacheHttp5Client;
import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature; import com.fasterxml.jackson.databind.SerializationFeature;
@ -60,7 +59,6 @@ public class ApiClient {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>(); apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
objectMapper = createObjectMapper(); objectMapper = createObjectMapper();
feignBuilder = Feign.builder() feignBuilder = Feign.builder()
.client(new ApacheHttp5Client())
.encoder(new FormEncoder(new JacksonEncoder(objectMapper))) .encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper)) .decoder(new ApiResponseDecoder(objectMapper))
.errorDecoder(new ApiErrorDecoder()) .errorDecoder(new ApiErrorDecoder())

2
samples/client/petstore/java/feign-no-nullable/src/main/java/org/openapitools/client/ApiClient.java
View File

@ -19,7 +19,6 @@ import java.util.function.Supplier;
import java.util.logging.Level; import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
import feign.okhttp.OkHttpClient;
import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature; import com.fasterxml.jackson.databind.SerializationFeature;
@ -59,7 +58,6 @@ public class ApiClient {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>(); apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
objectMapper = createObjectMapper(); objectMapper = createObjectMapper();
feignBuilder = Feign.builder() feignBuilder = Feign.builder()
.client(new OkHttpClient())
.encoder(new FormEncoder(new JacksonEncoder(objectMapper))) .encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper)) .decoder(new ApiResponseDecoder(objectMapper))
.errorDecoder(new ApiErrorDecoder()) .errorDecoder(new ApiErrorDecoder())

2
samples/client/petstore/java/feign/src/main/java/org/openapitools/client/ApiClient.java
View File

@ -19,7 +19,6 @@ import java.util.function.Supplier;
import java.util.logging.Level; import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
import feign.okhttp.OkHttpClient;
import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature; import com.fasterxml.jackson.databind.SerializationFeature;
@ -60,7 +59,6 @@ public class ApiClient {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>(); apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
objectMapper = createObjectMapper(); objectMapper = createObjectMapper();
feignBuilder = Feign.builder() feignBuilder = Feign.builder()
.client(new OkHttpClient())
.encoder(new FormEncoder(new JacksonEncoder(objectMapper))) .encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper)) .decoder(new ApiResponseDecoder(objectMapper))
.errorDecoder(new ApiErrorDecoder()) .errorDecoder(new ApiErrorDecoder())