loafle/openapi-generator
3
0
Fork 0
forked from loafle/openapi-generator-original
Code Pull Requests Activity

[csharp] fix authorization header casing issue (#16622)

Browse Source 
* Capitalise auth scheme irrespective of token_type capitalisation

* Changes from generate-samples.sh

* Add comment to change
This commit is contained in:
Graeme Wilson 2023-09-23 05:59:51 +01:00 committed by GitHub
parent 19d8dbc7d5
commit f99002a974
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 88 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/openapi-generator/src/main/resources/csharp/auth/OAuthAuthenticator.mustache vendored
View File

@ -81,7 +81,17 @@ namespace {{packageName}}.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClient-ConditionalSerialization/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClient-net47/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClient-net48/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClient-net5.0/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClientCore/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}

12
samples/client/petstore/csharp/OpenAPIClientCoreAndNet47/src/Org.OpenAPITools/Client/Auth/OAuthAuthenticator.cs
View File

@ -89,7 +89,17 @@ namespace Org.OpenAPITools.Client.Auth
.AddParameter("client_id", _clientId)
.AddParameter("client_secret", _clientSecret);
var response = await client.PostAsync<TokenResponse>(request).ConfigureAwait(false);
return $"{response.TokenType} {response.AccessToken}";
// RFC6749 - token_type is case insensitive.
// RFC6750 - In Authorization header Bearer should be capitalized.
// Fix the capitalization irrespective of token_type casing.
switch (response.TokenType?.ToLower())
{
case "bearer":
return $"Bearer {response.AccessToken}";
default:
return $"{response.TokenType} {response.AccessToken}";
}
}
}
}