Refactored Identifiers (#19270)

This commit is contained in:
congyuluo 2024-08-05 03:20:54 -07:00 committed by GitHub
parent eff3e6df53
commit f8a5051d9c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -62,14 +62,14 @@ public class WorkflowSettingsTest {
.withGlobalProperty("second", "2nd") .withGlobalProperty("second", "2nd")
.build(); .build();
Map<String, String> properties = modified.getGlobalProperties(); Map<String, String> globalProperties = modified.getGlobalProperties();
assertEquals(properties.size(), 2, "System Properties map should allow mutation when invoked via copy constructor"); assertEquals(globalProperties.size(), 2, "System Properties map should allow mutation when invoked via copy constructor");
assertEquals(properties.getOrDefault("first", ""), "1st"); assertEquals(globalProperties.getOrDefault("first", ""), "1st");
assertEquals(properties.getOrDefault("second", ""), "2nd"); assertEquals(globalProperties.getOrDefault("second", ""), "2nd");
} }
private void assertOnChangesToDefaults(WorkflowSettings defaults) { private void assertOnChangesToDefaults(WorkflowSettings defaultSettings) {
WorkflowSettings settings = WorkflowSettings.newBuilder() WorkflowSettings newSettings = WorkflowSettings.newBuilder()
.withOutputDir("output") .withOutputDir("output")
.withVerbose(true) .withVerbose(true)
.withSkipOverwrite(true) .withSkipOverwrite(true)
@ -81,32 +81,32 @@ public class WorkflowSettingsTest {
.withStrictSpecBehavior(false) .withStrictSpecBehavior(false)
.build(); .build();
assertNotEquals(defaults.getOutputDir(), settings.getOutputDir()); assertNotEquals(defaultSettings.getOutputDir(), newSettings.getOutputDir());
assertEquals(settings.getOutputDir(), Paths.get("output").toAbsolutePath().toString()); assertEquals(newSettings.getOutputDir(), Paths.get("output").toAbsolutePath().toString());
assertNotEquals(defaults.isVerbose(), settings.isVerbose()); assertNotEquals(defaultSettings.isVerbose(), newSettings.isVerbose());
assertTrue(settings.isVerbose()); assertTrue(newSettings.isVerbose());
assertNotEquals(defaults.isSkipOverwrite(), settings.isSkipOverwrite()); assertNotEquals(defaultSettings.isSkipOverwrite(), newSettings.isSkipOverwrite());
assertTrue(settings.isSkipOverwrite()); assertTrue(newSettings.isSkipOverwrite());
assertNotEquals(defaults.isRemoveOperationIdPrefix(), settings.isRemoveOperationIdPrefix()); assertNotEquals(defaultSettings.isRemoveOperationIdPrefix(), newSettings.isRemoveOperationIdPrefix());
assertTrue(settings.isRemoveOperationIdPrefix()); assertTrue(newSettings.isRemoveOperationIdPrefix());
assertNotEquals(defaults.isLogToStderr(), settings.isLogToStderr()); assertNotEquals(defaultSettings.isLogToStderr(), newSettings.isLogToStderr());
assertTrue(settings.isLogToStderr()); assertTrue(newSettings.isLogToStderr());
assertNotEquals(defaults.isValidateSpec(), settings.isValidateSpec()); assertNotEquals(defaultSettings.isValidateSpec(), newSettings.isValidateSpec());
assertFalse(settings.isValidateSpec()); assertFalse(newSettings.isValidateSpec());
assertNotEquals(defaults.isEnablePostProcessFile(), settings.isEnablePostProcessFile()); assertNotEquals(defaultSettings.isEnablePostProcessFile(), newSettings.isEnablePostProcessFile());
assertTrue(settings.isEnablePostProcessFile()); assertTrue(newSettings.isEnablePostProcessFile());
assertNotEquals(defaults.isEnableMinimalUpdate(), settings.isEnableMinimalUpdate()); assertNotEquals(defaultSettings.isEnableMinimalUpdate(), newSettings.isEnableMinimalUpdate());
assertTrue(settings.isEnableMinimalUpdate()); assertTrue(newSettings.isEnableMinimalUpdate());
assertNotEquals(defaults.isStrictSpecBehavior(), settings.isStrictSpecBehavior()); assertNotEquals(defaultSettings.isStrictSpecBehavior(), newSettings.isStrictSpecBehavior());
assertFalse(settings.isStrictSpecBehavior()); assertFalse(newSettings.isStrictSpecBehavior());
} }
@Test @Test