From 9dab57c2fb75993e813da8188c937f287bb56558 Mon Sep 17 00:00:00 2001 From: Jim Schubert Date: Thu, 4 May 2017 07:12:54 -0400 Subject: [PATCH 1/2] [csharp] warn on use of invokerPackage (#5551) --- .../io/swagger/codegen/languages/AbstractCSharpCodegen.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractCSharpCodegen.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractCSharpCodegen.java index e1e638a27699..05297736d0fa 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractCSharpCodegen.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractCSharpCodegen.java @@ -209,6 +209,10 @@ public abstract class AbstractCSharpCodegen extends DefaultCodegen implements Co } else { additionalProperties.put(CodegenConstants.PACKAGE_NAME, packageName); } + + if (additionalProperties.containsKey(CodegenConstants.INVOKER_PACKAGE)) { + LOGGER.warn(String.format("%s is not used by C# generators. Please use %s", CodegenConstants.INVOKER_PACKAGE, CodegenConstants.PACKAGE_NAME)); + } // {{packageTitle}} if (additionalProperties.containsKey(CodegenConstants.PACKAGE_TITLE)) { From d08d55d4190c916e2ce8c55be27a9da4eaa4b0e8 Mon Sep 17 00:00:00 2001 From: fisherliu Date: Thu, 4 May 2017 23:03:12 +0800 Subject: [PATCH 2/2] add @Valid annotion for bean-validation (#5517) --- .../src/main/resources/Java/beanValidation.mustache | 12 ++++++++++++ .../src/main/resources/Java/model.mustache | 1 + 2 files changed, 13 insertions(+) diff --git a/modules/swagger-codegen/src/main/resources/Java/beanValidation.mustache b/modules/swagger-codegen/src/main/resources/Java/beanValidation.mustache index c8c6946fef66..7c347758d8db 100644 --- a/modules/swagger-codegen/src/main/resources/Java/beanValidation.mustache +++ b/modules/swagger-codegen/src/main/resources/Java/beanValidation.mustache @@ -1,4 +1,16 @@ {{#required}} @NotNull {{/required}} +{{#isContainer}} +{{^isPrimitiveType}} +{{^isEnum}} + @Valid +{{/isEnum}} +{{/isPrimitiveType}} +{{/isContainer}} +{{#isNotContainer}} +{{^isPrimitiveType}} + @Valid +{{/isPrimitiveType}} +{{/isNotContainer}} {{>beanValidationCore}} \ No newline at end of file diff --git a/modules/swagger-codegen/src/main/resources/Java/model.mustache b/modules/swagger-codegen/src/main/resources/Java/model.mustache index 385b3c14ec9b..abb62a7af0f2 100644 --- a/modules/swagger-codegen/src/main/resources/Java/model.mustache +++ b/modules/swagger-codegen/src/main/resources/Java/model.mustache @@ -20,6 +20,7 @@ import android.os.Parcel; {{/parcelableModel}} {{#useBeanValidation}} import javax.validation.constraints.*; +import javax.validation.Valid; {{/useBeanValidation}} {{#models}}