From bf859c640e98b88e70ebafcd15781620626b16ff Mon Sep 17 00:00:00 2001 From: William Cheng Date: Mon, 15 Mar 2021 17:54:15 +0800 Subject: [PATCH] Better error handling for toExampleValue (#8940) * better error handling for toExampleValue * revise logging * update debug --- .../java/org/openapitools/codegen/DefaultCodegen.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java index a5fce66d29c..a2b93cfaef8 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java @@ -3103,7 +3103,14 @@ public class DefaultCodegen implements CodegenConfig { property.title = p.getTitle(); property.getter = toGetter(name); property.setter = toSetter(name); - property.example = toExampleValue(p); + // put toExampleValue in a try-catch block to log the error as example values are not critical + try { + property.example = toExampleValue(p); + } catch (Exception e) { + LOGGER.error("Error in generating `example` for the property {}. Default to ERROR_TO_EXAMPLE_VALUE. Enable debugging for more info.", property.baseName); + LOGGER.debug("Exception from toExampleValue: {}", e); + property.example = "ERROR_TO_EXAMPLE_VALUE"; + } property.defaultValue = toDefaultValue(p); property.defaultValueWithParam = toDefaultValueWithParam(name, p); property.jsonSchema = Json.pretty(p);