[c#][netcore] Skip readonly properties in serialization (#7883)

* skip readonly in serialization (c# netcore)

* minor wording change

modules/openapi-generator/src/main/resources/csharp-netcore/modelGeneric.mustache

@@ -35,6 +35,17 @@
         {{/description}}
         [DataMember(Name = "{{baseName}}"{{#required}}, IsRequired = true{{/required}}, EmitDefaultValue = {{#vendorExtensions.x-emit-default-value}}true{{/vendorExtensions.x-emit-default-value}}{{^vendorExtensions.x-emit-default-value}}{{#isNullable}}true{{/isNullable}}{{^isNullable}}false{{/isNullable}}{{/vendorExtensions.x-emit-default-value}})]
         public {{#complexType}}{{{complexType}}}{{/complexType}}{{^complexType}}{{{datatypeWithEnum}}}{{/complexType}}{{^isContainer}}{{^required}}?{{/required}}{{/isContainer}} {{name}} { get; set; }
+        {{#isReadOnly}}
+
+        /// <summary>
+        /// Returns false as {{name}} should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerialize{{name}}()
+        {
+            return false;
+        }
+        {{/isReadOnly}}
         {{/isEnum}}
         {{/vars}}
     {{#hasRequired}}
@@ -118,6 +129,17 @@
         {{/isDate}}
         public {{{dataType}}} {{name}} { get; {{#isReadOnly}}private {{/isReadOnly}}set; }
 
+        {{#isReadOnly}}
+        /// <summary>
+        /// Returns false as {{name}} should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerialize{{name}}()
+        {
+            return false;
+        }
+
+        {{/isReadOnly}}
         {{/isEnum}}
         {{/isInherited}}
         {{/vars}}

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/HasOnlyReadOnly.cs

@@ -47,12 +47,30 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "bar", EmitDefaultValue = false)]
         public string Bar { get; private set; }
 
+        /// <summary>
+        /// Returns false as Bar should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeBar()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Foo
         /// </summary>
         [DataMember(Name = "foo", EmitDefaultValue = false)]
         public string Foo { get; private set; }
 
+        /// <summary>
+        /// Returns false as Foo should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeFoo()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets additional properties
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Name.cs

@@ -64,6 +64,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "snake_case", EmitDefaultValue = false)]
         public int SnakeCase { get; private set; }
 
+        /// <summary>
+        /// Returns false as SnakeCase should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeSnakeCase()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Property
         /// </summary>
@@ -76,6 +85,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "123Number", EmitDefaultValue = false)]
         public int _123Number { get; private set; }
 
+        /// <summary>
+        /// Returns false as _123Number should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerialize_123Number()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets additional properties
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/ReadOnlyFirst.cs

@@ -48,6 +48,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "bar", EmitDefaultValue = false)]
         public string Bar { get; private set; }
 
+        /// <summary>
+        /// Returns false as Bar should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeBar()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Baz
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools.Test/JSONComposedSchemaTests.cs

@@ -27,7 +27,7 @@ namespace Org.OpenAPITools.Test
         /// Test GetServerUrl
         /// </summary>
         [Fact]
-        public void testOneOfSchemaAdditionalProperties()
+        public void TestOneOfSchemaAdditionalProperties()
         {
             // TODO
         }
@@ -36,7 +36,7 @@ namespace Org.OpenAPITools.Test
         /// Test GetServerUrl
         /// </summary>
         [Fact]
-        public void testOneOfSchemaWithDiscriminator()
+        public void TestOneOfSchemaWithDiscriminator()
         {
             // Mammal can be one of whale, pig and zebra.
             // pig has sub-classes.
@@ -45,7 +45,7 @@ namespace Org.OpenAPITools.Test
             Mammal m = Mammal.FromJson(str);
             Assert.NotNull(m);
             Assert.IsType<Whale>(m.ActualInstance);
-            
+
             String str2 = "{ \"className\": \"zebra\", \"type\": \"plains\" }";
             Mammal m2 = Mammal.FromJson(str2);
             Assert.NotNull(m2);
@@ -56,7 +56,7 @@ namespace Org.OpenAPITools.Test
         /// Test Fruit
         /// </summary>
         [Fact]
-        public void testFruit()
+        public void TestFruit()
         {
             Apple a = new Apple();
             a.Origin = "Japan";
@@ -95,5 +95,16 @@ namespace Org.OpenAPITools.Test
             // test custom serializer
             Assert.Equal("{\"lengthCm\":98.0}", JsonConvert.SerializeObject(f5));
         }
+
+        /// <summary>
+        /// ReadOnly property tests
+        /// </summary>
+        [Fact]
+        public void ReadOnlyFruit()
+        {
+            ReadOnlyFirst r = JsonConvert.DeserializeObject<ReadOnlyFirst>("{\"baz\":\"from json gaz\",\"bar\":\"from json bar\"}");
+            Assert.Equal("from json bar", r.Bar);
+            Assert.Equal("{\"baz\":\"from json gaz\"}", JsonConvert.SerializeObject(r));
+        }
     }
 }

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/HasOnlyReadOnly.cs

@@ -47,12 +47,30 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "bar", EmitDefaultValue = false)]
         public string Bar { get; private set; }
 
+        /// <summary>
+        /// Returns false as Bar should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeBar()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Foo
         /// </summary>
         [DataMember(Name = "foo", EmitDefaultValue = false)]
         public string Foo { get; private set; }
 
+        /// <summary>
+        /// Returns false as Foo should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeFoo()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets additional properties
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Name.cs

@@ -64,6 +64,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "snake_case", EmitDefaultValue = false)]
         public int SnakeCase { get; private set; }
 
+        /// <summary>
+        /// Returns false as SnakeCase should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeSnakeCase()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Property
         /// </summary>
@@ -76,6 +85,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "123Number", EmitDefaultValue = false)]
         public int _123Number { get; private set; }
 
+        /// <summary>
+        /// Returns false as _123Number should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerialize_123Number()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets additional properties
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/ReadOnlyFirst.cs

@@ -48,6 +48,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "bar", EmitDefaultValue = false)]
         public string Bar { get; private set; }
 
+        /// <summary>
+        /// Returns false as Bar should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeBar()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Baz
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/HasOnlyReadOnly.cs

@@ -46,12 +46,30 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "bar", EmitDefaultValue = false)]
         public string Bar { get; private set; }
 
+        /// <summary>
+        /// Returns false as Bar should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeBar()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Foo
         /// </summary>
         [DataMember(Name = "foo", EmitDefaultValue = false)]
         public string Foo { get; private set; }
 
+        /// <summary>
+        /// Returns false as Foo should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeFoo()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Returns the string presentation of the object
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/Name.cs

@@ -60,6 +60,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "snake_case", EmitDefaultValue = false)]
         public int SnakeCase { get; private set; }
 
+        /// <summary>
+        /// Returns false as SnakeCase should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeSnakeCase()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Property
         /// </summary>
@@ -72,6 +81,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "123Number", EmitDefaultValue = false)]
         public int _123Number { get; private set; }
 
+        /// <summary>
+        /// Returns false as _123Number should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerialize_123Number()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Returns the string presentation of the object
         /// </summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/ReadOnlyFirst.cs

@@ -47,6 +47,15 @@ namespace Org.OpenAPITools.Model
         [DataMember(Name = "bar", EmitDefaultValue = false)]
         public string Bar { get; private set; }
 
+        /// <summary>
+        /// Returns false as Bar should not be serialized given that it's read-only.
+        /// </summary>
+        /// <returns>false (boolean)</returns>
+        public bool ShouldSerializeBar()
+        {
+            return false;
+        }
+
         /// <summary>
         /// Gets or Sets Baz
         /// </summary>