loafle/openapi-generator
3
0
Fork 0
forked from loafle/openapi-generator-original
Code Pull Requests Activity

[PHP] Fix parentSchema conditional causing parent call when parent isn't present (#8705)

Browse Source 
* Fix parentSchema conditional

we cannot call `parent::` if parent isn't present. Everywhere else in the schema we're checking for `{{parentSchema}}` but here we're checking for `{{parent}}` which is causing errors when parent is not present

* Update samples
This commit is contained in:
Andre Praca 2021-04-28 10:08:50 +03:00 committed by GitHub
parent 4aaaae765b
commit ad9e2395ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
modules/openapi-generator/src/main/resources/php/model_generic.mustache vendored
View File

@ -188,12 +188,12 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}}{{/parentSchema}}{{^par
*/ */
public function listInvalidProperties() public function listInvalidProperties()
{ {
{{#parent}} {{#parentSchema}}
$invalidProperties = parent::listInvalidProperties(); $invalidProperties = parent::listInvalidProperties();
{{/parent}} {{/parentSchema}}
{{^parent}} {{^parentSchema}}
$invalidProperties = []; $invalidProperties = [];
{{/parent}} {{/parentSchema}}
{{#vars}} {{#vars}}
{{#required}} {{#required}}

2
samples/client/petstore/php/OpenAPIClient-php/lib/Model/NullableClass.php
View File

@ -254,7 +254,7 @@ class NullableClass implements ModelInterface, ArrayAccess, \JsonSerializable
*/ */
public function listInvalidProperties() public function listInvalidProperties()
{ {
$invalidProperties = parent::listInvalidProperties(); $invalidProperties = [];
return $invalidProperties; return $invalidProperties;
} }