[javascript] Use arrow function with usePromises in ES6 ApiClient.js for superagent callback to preserve this context (#5814)

This commit is contained in:
Kevin Murphy 2017-06-18 09:27:52 -07:00 committed by wing328
parent 7893f759e0
commit aa37b9747f
2 changed files with 10 additions and 7 deletions

View File

@ -449,7 +449,7 @@ export default class ApiClient {
}
{{#usePromises}}return new Promise((resolve, reject) => {
request.end(function(error, response) {
request.end((error, response) => {
if (error) {
reject(error);
} else {

View File

@ -173,13 +173,16 @@
* @returns {Boolean} <code>true</code> if <code>param</code> represents a file.
*/
exports.prototype.isFileParam = function(param) {
// fs.ReadStream in Node.js (but not in runtime like browserify)
if (typeof window === 'undefined' &&
typeof require === 'function' &&
require('fs') &&
param instanceof require('fs').ReadStream) {
// fs.ReadStream in Node.js and Electron (but not in runtime like browserify)
if (typeof require === 'function') {
var fs;
try {
fs = require('fs');
} catch (err) {}
if (fs && fs.ReadStream && param instanceof fs.ReadStream) {
return true;
}
}
// Buffer in Node.js
if (typeof Buffer === 'function' && param instanceof Buffer) {
return true;