From a18494bd8eaf8e454ce5eb70d4fa0755caddace2 Mon Sep 17 00:00:00 2001 From: William Cheng Date: Thu, 19 Dec 2019 11:17:47 +0800 Subject: [PATCH] Test kotlin-json-request-date in CI (#4824) * test kotlin-json-request-date in ci * minor code formatting * add pom.xml for testing * fix permission --- .../languages/KotlinClientCodegen.java | 4 +- .../languages/KotlinServerCodegen.java | 4 +- .../languages/KotlinSpringServerCodegen.java | 2 +- pom.xml | 1 + .../petstore/kotlin-json-request-date/pom.xml | 46 +++++++++++++++++++ 5 files changed, 52 insertions(+), 5 deletions(-) create mode 100644 samples/client/petstore/kotlin-json-request-date/pom.xml diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinClientCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinClientCodegen.java index b1407a71f325..fdb26f937b5d 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinClientCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinClientCodegen.java @@ -238,9 +238,9 @@ public class KotlinClientCodegen extends AbstractKotlinCodegen { } private void processRequestDateConverter() { - if(RequestDateConverter.TO_JSON.value.equals(requestDateConverter)) { + if (RequestDateConverter.TO_JSON.value.equals(requestDateConverter)) { additionalProperties.put(RequestDateConverter.TO_JSON.value, true); - } else if(RequestDateConverter.TO_STRING.value.equals(requestDateConverter)) { + } else if (RequestDateConverter.TO_STRING.value.equals(requestDateConverter)) { additionalProperties.put(RequestDateConverter.TO_STRING.value, true); } } diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java index 4bd48eb2188e..de4b755c2bca 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java @@ -145,7 +145,7 @@ public class KotlinServerCodegen extends AbstractKotlinCodegen { super.processOpts(); if (additionalProperties.containsKey(CodegenConstants.LIBRARY)) { - this.setLibrary((String) additionalProperties.get(CodegenConstants.LIBRARY)); + this.setLibrary((String) additionalProperties.get(CodegenConstants.LIBRARY)); } // set default library to "ktor" @@ -185,7 +185,7 @@ public class KotlinServerCodegen extends AbstractKotlinCodegen { additionalProperties.put(Constants.COMPRESSION, getCompressionFeatureEnabled()); } - boolean generateApis = additionalProperties.containsKey(CodegenConstants.GENERATE_APIS) && (Boolean)additionalProperties.get(CodegenConstants.GENERATE_APIS); + boolean generateApis = additionalProperties.containsKey(CodegenConstants.GENERATE_APIS) && (Boolean) additionalProperties.get(CodegenConstants.GENERATE_APIS); String packageFolder = (sourceFolder + File.separator + packageName).replace(".", File.separator); String resourcesFolder = "src/main/resources"; // not sure this can be user configurable. diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java index a64ffc12eaab..fa884f1bd23a 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java @@ -639,7 +639,7 @@ public class KotlinSpringServerCodegen extends AbstractKotlinCodegen @Override public String toModelName(final String name) { // Allow for explicitly configured spring.* - if (name.startsWith("org.springframework.") ) { + if (name.startsWith("org.springframework.")) { return name; } return super.toModelName(name); diff --git a/pom.xml b/pom.xml index 8b7adc8f50d3..18418998807c 100644 --- a/pom.xml +++ b/pom.xml @@ -1260,6 +1260,7 @@ samples/client/petstore/kotlin-threetenbp/ samples/client/petstore/kotlin-string/ samples/client/petstore/kotlin-moshi-codegen/ + samples/client/petstore/kotlin-json-request-date/ samples/server/petstore/erlang-server samples/server/petstore/jaxrs/jersey2 diff --git a/samples/client/petstore/kotlin-json-request-date/pom.xml b/samples/client/petstore/kotlin-json-request-date/pom.xml new file mode 100644 index 000000000000..27124bdb9013 --- /dev/null +++ b/samples/client/petstore/kotlin-json-request-date/pom.xml @@ -0,0 +1,46 @@ + + 4.0.0 + io.swagger + KotlinJsonRequestDateClientTests + pom + 1.0-SNAPSHOT + Kotlin Moshi Petstore Client + + + + maven-dependency-plugin + + + package + + copy-dependencies + + + ${project.build.directory} + + + + + + org.codehaus.mojo + exec-maven-plugin + 1.2.1 + + + bundle-test + integration-test + + exec + + + gradle + + test + + + + + + + +