diff --git a/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/auth/HttpBasicAuth.mustache b/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/auth/HttpBasicAuth.mustache
index 76fa4a2d0a3..f3ed85d980b 100644
--- a/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/auth/HttpBasicAuth.mustache
+++ b/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/auth/HttpBasicAuth.mustache
@@ -2,7 +2,7 @@ package {{invokerPackage}}.auth;
import {{invokerPackage}}.Pair;
-import com.migcomponents.migbase64.Base64;
+import com.squareup.okhttp.Credentials;
import java.util.Map;
import java.util.List;
@@ -34,11 +34,8 @@ public class HttpBasicAuth implements Authentication {
if (username == null && password == null) {
return;
}
- String str = (username == null ? "" : username) + ":" + (password == null ? "" : password);
- try {
- headerParams.put("Authorization", "Basic " + Base64.encodeToString(str.getBytes("UTF-8"), false));
- } catch (UnsupportedEncodingException e) {
- throw new RuntimeException(e);
- }
+ headerParams.put("Authorization", Credentials.basic(
+ username == null ? "" : username,
+ password == null ? "" : password));
}
}
diff --git a/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/pom.mustache b/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/pom.mustache
index 67fc10e8323..0d7e9015101 100644
--- a/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/pom.mustache
+++ b/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/pom.mustache
@@ -122,11 +122,6 @@
gson
${gson-version}
-
- com.brsanthu
- migbase64
- 2.2
-
diff --git a/samples/client/petstore/java/okhttp-gson/pom.xml b/samples/client/petstore/java/okhttp-gson/pom.xml
index 2442e1c318e..9fa057be939 100644
--- a/samples/client/petstore/java/okhttp-gson/pom.xml
+++ b/samples/client/petstore/java/okhttp-gson/pom.xml
@@ -122,11 +122,6 @@
gson
${gson-version}
-
- com.brsanthu
- migbase64
- 2.2
-
diff --git a/samples/client/petstore/java/okhttp-gson/src/main/java/io/swagger/client/auth/HttpBasicAuth.java b/samples/client/petstore/java/okhttp-gson/src/main/java/io/swagger/client/auth/HttpBasicAuth.java
index 38617121e30..6ed16d1db30 100644
--- a/samples/client/petstore/java/okhttp-gson/src/main/java/io/swagger/client/auth/HttpBasicAuth.java
+++ b/samples/client/petstore/java/okhttp-gson/src/main/java/io/swagger/client/auth/HttpBasicAuth.java
@@ -2,7 +2,7 @@ package io.swagger.client.auth;
import io.swagger.client.Pair;
-import com.migcomponents.migbase64.Base64;
+import com.squareup.okhttp.Credentials;
import java.util.Map;
import java.util.List;
@@ -34,11 +34,8 @@ public class HttpBasicAuth implements Authentication {
if (username == null && password == null) {
return;
}
- String str = (username == null ? "" : username) + ":" + (password == null ? "" : password);
- try {
- headerParams.put("Authorization", "Basic " + Base64.encodeToString(str.getBytes("UTF-8"), false));
- } catch (UnsupportedEncodingException e) {
- throw new RuntimeException(e);
- }
+ headerParams.put("Authorization", Credentials.basic(
+ username == null ? "" : username,
+ password == null ? "" : password));
}
}
diff --git a/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/ApiKeyAuthTest.java b/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/ApiKeyAuthTest.java
index 5bdb4fb78fb..3715e9724e6 100644
--- a/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/ApiKeyAuthTest.java
+++ b/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/ApiKeyAuthTest.java
@@ -29,9 +29,23 @@ public class ApiKeyAuthTest {
assertEquals(0, headerParams.size());
}
+ @Test
+ public void testApplyToParamsInQueryWithNullValue() {
+ List queryParams = new ArrayList();
+ Map headerParams = new HashMap();
+
+ ApiKeyAuth auth = new ApiKeyAuth("query", "api_key");
+ auth.setApiKey(null);
+ auth.applyToParams(queryParams, headerParams);
+
+ // no changes to parameters
+ assertEquals(0, queryParams.size());
+ assertEquals(0, headerParams.size());
+ }
+
@Test
public void testApplyToParamsInHeaderWithPrefix() {
- List queryParams = new ArrayList();
+ List queryParams = new ArrayList();
Map headerParams = new HashMap();
ApiKeyAuth auth = new ApiKeyAuth("header", "X-API-TOKEN");
@@ -44,4 +58,19 @@ public class ApiKeyAuthTest {
assertEquals(1, headerParams.size());
assertEquals("Token my-api-token", headerParams.get("X-API-TOKEN"));
}
+
+ @Test
+ public void testApplyToParamsInHeaderWithNullValue() {
+ List queryParams = new ArrayList();
+ Map headerParams = new HashMap();
+
+ ApiKeyAuth auth = new ApiKeyAuth("header", "X-API-TOKEN");
+ auth.setApiKey(null);
+ auth.setApiKeyPrefix("Token");
+ auth.applyToParams(queryParams, headerParams);
+
+ // no changes to parameters
+ assertEquals(0, queryParams.size());
+ assertEquals(0, headerParams.size());
+ }
}
diff --git a/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/HttpBasicAuthTest.java b/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/HttpBasicAuthTest.java
index 52c5497ba83..ddee04f57fc 100644
--- a/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/HttpBasicAuthTest.java
+++ b/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/auth/HttpBasicAuthTest.java
@@ -48,5 +48,15 @@ public class HttpBasicAuthTest {
// the string below is base64-encoded result of "my-username:" with the "Basic " prefix
expected = "Basic bXktdXNlcm5hbWU6";
assertEquals(expected, headerParams.get("Authorization"));
+
+ // null username and password should be ignored
+ queryParams = new ArrayList();
+ headerParams = new HashMap();
+ auth.setUsername(null);
+ auth.setPassword(null);
+ auth.applyToParams(queryParams, headerParams);
+ // no changes to parameters
+ assertEquals(0, queryParams.size());
+ assertEquals(0, headerParams.size());
}
}