loafle/openapi-generator
3
0
Fork 0
forked from loafle/openapi-generator-original
Code Pull Requests Activity

Fix single quote escaping for python code generator (and its test) (#21021)

Browse Source 
Hard to spot, but in Java the strings "'" and "\'" are identical, so
the implementation and its test were broken identically.
This commit is contained in:
Curd Becker 2025-04-07 19:10:09 +02:00 committed by GitHub
parent 63afd455f7
commit 7a3ea2872a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java
View File

@ -214,7 +214,7 @@ public abstract class AbstractPythonCodegen extends DefaultCodegen implements Co
String defaultValue = String.valueOf(p.getDefault()); String defaultValue = String.valueOf(p.getDefault());
if (defaultValue != null) { if (defaultValue != null) {
defaultValue = defaultValue.replace("\\", "\\\\") defaultValue = defaultValue.replace("\\", "\\\\")
.replace("'", "\'"); .replace("'", "\\'");
if (Pattern.compile("\r\n|\r|\n").matcher(defaultValue).find()) { if (Pattern.compile("\r\n|\r|\n").matcher(defaultValue).find()) {
return "'''" + defaultValue + "'''"; return "'''" + defaultValue + "'''";
} else { } else {

2
modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonClientCodegenTest.java
View File

@ -139,7 +139,7 @@ public class PythonClientCodegenTest {
StringSchema schema = new StringSchema(); StringSchema schema = new StringSchema();
schema.setDefault("Text containing 'single' quote"); schema.setDefault("Text containing 'single' quote");
String defaultValue = codegen.toDefaultValue(schema); String defaultValue = codegen.toDefaultValue(schema);
Assert.assertEquals("'Text containing \'single\' quote'", defaultValue); Assert.assertEquals("'Text containing \\'single\\' quote'", defaultValue);
} }
@Test(description = "test backslash default") @Test(description = "test backslash default")