From 5223c80c6da3649b8411dacaf99a3180cea912cd Mon Sep 17 00:00:00 2001 From: Mykola Yashchenko Date: Tue, 25 Jul 2017 18:43:56 +0300 Subject: [PATCH] generate boolean getter method according to a code convention (#6169) --- .../java/io/swagger/codegen/DefaultCodegen.java | 1 + .../codegen/staticDocs/StaticOperationTest.java | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java index 92f1a483c0f..7c5f7a03d48 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java @@ -1660,6 +1660,7 @@ public class DefaultCodegen { } if (p instanceof BooleanProperty) { property.isBoolean = true; + property.getter = "is" + getterAndSetterCapitalize(name); } if (p instanceof BinaryProperty) { property.isBinary = true; diff --git a/modules/swagger-codegen/src/test/java/io/swagger/codegen/staticDocs/StaticOperationTest.java b/modules/swagger-codegen/src/test/java/io/swagger/codegen/staticDocs/StaticOperationTest.java index 6b16b3b7f5b..dc715867b39 100644 --- a/modules/swagger-codegen/src/test/java/io/swagger/codegen/staticDocs/StaticOperationTest.java +++ b/modules/swagger-codegen/src/test/java/io/swagger/codegen/staticDocs/StaticOperationTest.java @@ -4,6 +4,7 @@ import io.swagger.codegen.CodegenProperty; import io.swagger.codegen.DefaultCodegen; import io.swagger.codegen.languages.StaticDocCodegen; import io.swagger.models.properties.ArrayProperty; +import io.swagger.models.properties.BooleanProperty; import io.swagger.models.properties.RefProperty; import io.swagger.models.properties.StringProperty; @@ -26,6 +27,21 @@ public class StaticOperationTest { Assert.assertTrue(cp.isNotContainer); } + @Test(description = "convert a boolean parameter") + public void booleanParameterTest() { + final BooleanProperty property = new BooleanProperty(); + final DefaultCodegen codegen = new StaticDocCodegen(); + final CodegenProperty cp = codegen.fromProperty("property", property); + + Assert.assertEquals(cp.baseName, "property"); + Assert.assertEquals(cp.datatype, "Boolean"); + Assert.assertEquals(cp.name, "property"); + Assert.assertEquals(cp.baseType, "boolean"); + Assert.assertTrue(cp.isNotContainer); + Assert.assertTrue(cp.isBoolean); + Assert.assertEquals(cp.getter, "isProperty"); + } + @Test(description = "convert a complex parameter") public void complexParameterTest() { final RefProperty property = new RefProperty("Children");