loafle/openapi-generator
3
0
Fork 0
forked from loafle/openapi-generator-original
Code Pull Requests Activity

[PHP] Enhance Symfony generator (#12532)

Browse Source 
* Enhance Symfony generator

  - Add missing typehints
  - Add missing use statements
  - Simplify model ctor
  - Change fallthrough Exception to Throwable
  - prevent storing result of void methods
  - fix validate method
  - add default null values to model properties
  - simplify API interface return values
  - fix/rework default value implementation
  - fix optional params deprecation warnings
  - ..

For more details check out the PR: https://github.com/OpenAPITools/openapi-generator/pull/12532

* Enhance Symfony generator Tests

  - Skip risky tests
  - Fix type hint error
  - Fix class exists tests
  - Fix broken doc block
  - Enhance annotations
  - Update phpunit.xml.dist
  - Fix test config resource location
This commit is contained in:
Daniel Metzner
2022-06-25 14:53:21 +02:00
committed by GitHub
parent 286a31c019
commit 3b15bb8a4e
56 changed files with 862 additions and 558 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php
View File

@@ -114,6 +114,7 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 200;
$responseHeaders = [];
$result = $handler->addPet($pet, $responseCode, $responseHeaders);
// Find default response message
@@ -140,7 +141,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -198,7 +199,8 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 204;
$responseHeaders = [];
$result = $handler->deletePet($petId, $apiKey, $responseCode, $responseHeaders);
$handler->deletePet($petId, $apiKey, $responseCode, $responseHeaders);
// Find default response message
$message = '';
@@ -220,7 +222,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -286,6 +288,7 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 200;
$responseHeaders = [];
$result = $handler->findPetsByStatus($status, $responseCode, $responseHeaders);
// Find default response message
@@ -312,7 +315,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -376,6 +379,7 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 200;
$responseHeaders = [];
$result = $handler->findPetsByTags($tags, $responseCode, $responseHeaders);
// Find default response message
@@ -402,7 +406,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -461,6 +465,7 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 200;
$responseHeaders = [];
$result = $handler->getPetById($petId, $responseCode, $responseHeaders);
// Find default response message
@@ -490,7 +495,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -559,6 +564,7 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 200;
$responseHeaders = [];
$result = $handler->updatePet($pet, $responseCode, $responseHeaders);
// Find default response message
@@ -591,7 +597,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -657,7 +663,8 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 204;
$responseHeaders = [];
$result = $handler->updatePetWithForm($petId, $name, $status, $responseCode, $responseHeaders);
$handler->updatePetWithForm($petId, $name, $status, $responseCode, $responseHeaders);
// Find default response message
$message = '';
@@ -679,7 +686,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}
@@ -753,6 +760,7 @@ class PetController extends Controller
// Make the call to the business logic
$responseCode = 200;
$responseHeaders = [];
$result = $handler->uploadFile($petId, $additionalMetadata, $file, $responseCode, $responseHeaders);
// Find default response message
@@ -776,7 +784,7 @@ class PetController extends Controller
]
)
);
} catch (Exception $fallthrough) {
} catch (\Throwable $fallthrough) {
return $this->createErrorResponse(new HttpException(500, 'An unsuspected error occurred.', $fallthrough));
}
}