[Golang][client] fix file suffix for _test.go (#449)

* add file suffix fix for _test.go

* Trigger CI due to previous Shippable race condition

* Trigger CI due to previous Shippable race condition

* Trigger CI due to previous Travis CI stall

* Trigger CI due to previous Travis CI stall

* Trigger CI due to previous Shippable race condition

* add Go client test testFilenames

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractGoCodegen.java

@@ -201,7 +201,12 @@ public abstract class AbstractGoCodegen extends DefaultCodegen implements Codege
 
     @Override
     public String toModelFilename(String name) {
-        return toModel("model_" + name);
+        name = toModel("model_" + name);
+        if (name.endsWith("_test")) {
+            LOGGER.warn(name + ".go with `_test.go` suffix (reserved word) cannot be used as filename. Renamed to " + name + "_.go");
+            name += "_";
+        }
+        return name;
     }
 
     public String toModel(String name) {
@@ -237,7 +242,12 @@ public abstract class AbstractGoCodegen extends DefaultCodegen implements Codege
         name = name.replaceAll("-", "_"); // FIXME: a parameter should not be assigned. Also declare the methods parameters as 'final'.
 
         // e.g. PetApi.go => pet_api.go
-        return "api_" + underscore(name);
+        name = "api_" + underscore(name);
+        if (name.endsWith("_test")) {
+            LOGGER.warn(name + ".go with `_test.go` suffix (reserved word) cannot be used as filename. Renamed to " + name + "_.go");
+            name += "_";
+        }
+        return name;
     }
 
     @Override

modules/openapi-generator/src/test/java/org/openapitools/codegen/go/GoClientCodegenTest.java

@@ -72,4 +72,21 @@ public class GoClientCodegenTest {
         Assert.assertFalse(bp.isPrimitiveType);
     }
 
+    @Test
+    public void testFilenames() throws Exception {
+        final GoClientCodegen codegen = new GoClientCodegen();
+
+        // Model names are generated from schema / definition names
+        Assert.assertEquals(codegen.toModelFilename("Animal"), "model_animal");
+        Assert.assertEquals(codegen.toModelFilename("AnimalTest"), "model_animal_test_");
+        Assert.assertEquals(codegen.toModelFilename("AnimalFarm"), "model_animal_farm");
+        Assert.assertEquals(codegen.toModelFilename("AnimalFarmTest"), "model_animal_farm_test_");
+
+        // API names are generated from tag names
+        Assert.assertEquals(codegen.toApiFilename("Animal"), "api_animal");
+        Assert.assertEquals(codegen.toApiFilename("Animal Test"), "api_animal_test_");
+        Assert.assertEquals(codegen.toApiFilename("Animal Farm"), "api_animal_farm");
+        Assert.assertEquals(codegen.toApiFilename("Animal Farm Test"), "api_animal_farm_test_");
+    }
+
 }

samples/client/petstore/go/go-petstore/docs/ModelApiResponse.md

@@ -1,12 +0,0 @@
-# ModelApiResponse
-
-## Properties
-Name | Type | Description | Notes
------------- | ------------- | ------------- | -------------
-**Code** | **int32** |  | [optional] [default to null]
-**Type_** | **string** |  | [optional] [default to null]
-**Message** | **string** |  | [optional] [default to null]
-
-[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
-
-

samples/client/petstore/go/go-petstore/docs/ModelReturn.md

@@ -1,10 +0,0 @@
-# ModelReturn
-
-## Properties
-Name | Type | Description | Notes
------------- | ------------- | ------------- | -------------
-**Return_** | **int32** |  | [optional] [default to null]
-
-[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
-
-

samples/client/petstore/go/go-petstore/docs/OuterBoolean.md

@@ -1,9 +0,0 @@
-# OuterBoolean
-
-## Properties
-Name | Type | Description | Notes
------------- | ------------- | ------------- | -------------
-
-[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
-
-

samples/client/petstore/go/go-petstore/docs/OuterNumber.md

@@ -1,9 +0,0 @@
-# OuterNumber
-
-## Properties
-Name | Type | Description | Notes
------------- | ------------- | ------------- | -------------
-
-[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
-
-

samples/client/petstore/go/go-petstore/docs/OuterString.md

@@ -1,9 +0,0 @@
-# OuterString
-
-## Properties
-Name | Type | Description | Notes
------------- | ------------- | ------------- | -------------
-
-[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
-
-

samples/client/petstore/go/go-petstore/model_outer_boolean.go

@@ -1,14 +0,0 @@
-/*
- * Swagger Petstore
- *
- * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
- *
- * API version: 1.0.0
- * Contact: apiteam@swagger.io
- * Generated by: Swagger Codegen (https://github.com/swagger-api/swagger-codegen.git)
- */
-
-package petstore
-
-type OuterBoolean struct {
-}

samples/client/petstore/go/go-petstore/model_outer_number.go

@@ -1,14 +0,0 @@
-/*
- * Swagger Petstore
- *
- * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
- *
- * API version: 1.0.0
- * Contact: apiteam@swagger.io
- * Generated by: Swagger Codegen (https://github.com/swagger-api/swagger-codegen.git)
- */
-
-package petstore
-
-type OuterNumber struct {
-}

samples/client/petstore/go/go-petstore/model_outer_string.go

@@ -1,14 +0,0 @@
-/*
- * Swagger Petstore
- *
- * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
- *
- * API version: 1.0.0
- * Contact: apiteam@swagger.io
- * Generated by: Swagger Codegen (https://github.com/swagger-api/swagger-codegen.git)
- */
-
-package petstore
-
-type OuterString struct {
-}