From 29ca272a95c8134f7ff35fb4d59450a1e5ade576 Mon Sep 17 00:00:00 2001 From: William Cheng Date: Fri, 25 Sep 2020 00:25:23 +0800 Subject: [PATCH] regenerate java pkmst petstore samples (#7502) --- .../com/prokarma/pkmst/controller/PetApi.java | 64 ++++++++++--------- .../prokarma/pkmst/controller/StoreApi.java | 34 +++++----- .../prokarma/pkmst/controller/UserApi.java | 52 +++++++-------- .../prokarma/pkmst/controller/PetApiTest.java | 32 +++++----- .../pkmst/controller/StoreApiTest.java | 16 ++--- .../pkmst/controller/UserApiTest.java | 28 ++++---- 6 files changed, 114 insertions(+), 112 deletions(-) diff --git a/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/PetApi.java b/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/PetApi.java index 532a7a2dbca..e468c895ffb 100644 --- a/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/PetApi.java +++ b/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/PetApi.java @@ -11,13 +11,7 @@ import com.prokarma.pkmst.model.Pet; import io.swagger.annotations.*; import org.springframework.http.ResponseEntity; -import org.springframework.web.bind.annotation.PathVariable; -import org.springframework.web.bind.annotation.RequestBody; -import org.springframework.web.bind.annotation.RequestHeader; -import org.springframework.web.bind.annotation.RequestMapping; -import org.springframework.web.bind.annotation.RequestMethod; -import org.springframework.web.bind.annotation.RequestParam; -import org.springframework.web.bind.annotation.RequestPart; +import org.springframework.web.bind.annotation.*; import org.springframework.web.multipart.MultipartFile; import java.io.IOException; @@ -39,9 +33,10 @@ public interface PetApi { }, tags={ "pet", }) @ApiResponses(value = { @ApiResponse(code = 405, message = "Invalid input") }) - @RequestMapping(value = "/pet", - consumes = { "application/json", "application/xml" }, - method = RequestMethod.POST) + @PostMapping( + value = "/pet", + consumes = { "application/json", "application/xml" } + ) ResponseEntity addPet(@ApiParam(value = "Pet object that needs to be added to the store" ,required=true ) @RequestBody Pet body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -53,8 +48,9 @@ public interface PetApi { }, tags={ "pet", }) @ApiResponses(value = { @ApiResponse(code = 400, message = "Invalid pet value") }) - @RequestMapping(value = "/pet/{petId}", - method = RequestMethod.DELETE) + @DeleteMapping( + value = "/pet/{petId}" + ) ResponseEntity deletePet(@ApiParam(value = "Pet id to delete",required=true ) @PathVariable("petId") Long petId,@ApiParam(value = "" ) @RequestHeader(value="api_key", required=false) String apiKey, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -67,9 +63,10 @@ public interface PetApi { @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation", response = Pet.class, responseContainer = "List"), @ApiResponse(code = 400, message = "Invalid status value") }) - @RequestMapping(value = "/pet/findByStatus", - produces = { "application/xml", "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/pet/findByStatus", + produces = { "application/xml", "application/json" } + ) ResponseEntity> findPetsByStatus(@ApiParam(value = "Status values that need to be considered for filter", required = true, allowableValues = "available, pending, sold", defaultValue = "new ArrayList<>()") @RequestParam(value = "status", required = true, defaultValue="new ArrayList<>()") List status, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -82,9 +79,10 @@ public interface PetApi { @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation", response = Pet.class, responseContainer = "List"), @ApiResponse(code = 400, message = "Invalid tag value") }) - @RequestMapping(value = "/pet/findByTags", - produces = { "application/xml", "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/pet/findByTags", + produces = { "application/xml", "application/json" } + ) ResponseEntity> findPetsByTags(@ApiParam(value = "Tags to filter by", required = true, defaultValue = "new ArrayList<>()") @RequestParam(value = "tags", required = true, defaultValue="new ArrayList<>()") List tags, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -95,9 +93,10 @@ public interface PetApi { @ApiResponse(code = 200, message = "successful operation", response = Pet.class), @ApiResponse(code = 400, message = "Invalid ID supplied"), @ApiResponse(code = 404, message = "Pet not found") }) - @RequestMapping(value = "/pet/{petId}", - produces = { "application/xml", "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/pet/{petId}", + produces = { "application/xml", "application/json" } + ) ResponseEntity getPetById(@ApiParam(value = "ID of pet to return",required=true ) @PathVariable("petId") Long petId, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -111,9 +110,10 @@ public interface PetApi { @ApiResponse(code = 400, message = "Invalid ID supplied"), @ApiResponse(code = 404, message = "Pet not found"), @ApiResponse(code = 405, message = "Validation exception") }) - @RequestMapping(value = "/pet", - consumes = { "application/json", "application/xml" }, - method = RequestMethod.PUT) + @PutMapping( + value = "/pet", + consumes = { "application/json", "application/xml" } + ) ResponseEntity updatePet(@ApiParam(value = "Pet object that needs to be added to the store" ,required=true ) @RequestBody Pet body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -125,9 +125,10 @@ public interface PetApi { }, tags={ "pet", }) @ApiResponses(value = { @ApiResponse(code = 405, message = "Invalid input") }) - @RequestMapping(value = "/pet/{petId}", - consumes = { "application/x-www-form-urlencoded" }, - method = RequestMethod.POST) + @PostMapping( + value = "/pet/{petId}", + consumes = { "application/x-www-form-urlencoded" } + ) ResponseEntity updatePetWithForm(@ApiParam(value = "ID of pet that needs to be updated",required=true ) @PathVariable("petId") Long petId,@ApiParam(value = "Updated name of the pet") @RequestPart(value="name", required=false) String name,@ApiParam(value = "Updated status of the pet") @RequestPart(value="status", required=false) String status, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -139,10 +140,11 @@ public interface PetApi { }, tags={ "pet", }) @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation", response = ModelApiResponse.class) }) - @RequestMapping(value = "/pet/{petId}/uploadImage", - produces = { "application/json" }, - consumes = { "multipart/form-data" }, - method = RequestMethod.POST) + @PostMapping( + value = "/pet/{petId}/uploadImage", + produces = { "application/json" }, + consumes = { "multipart/form-data" } + ) ResponseEntity uploadFile(@ApiParam(value = "ID of pet to update",required=true ) @PathVariable("petId") Long petId,@ApiParam(value = "Additional data to pass to server") @RequestPart(value="additionalMetadata", required=false) String additionalMetadata,@ApiParam(value = "file detail") @RequestPart("file") MultipartFile file, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; } diff --git a/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/StoreApi.java b/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/StoreApi.java index ff31820b354..e6efb7af180 100644 --- a/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/StoreApi.java +++ b/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/StoreApi.java @@ -10,13 +10,7 @@ import com.prokarma.pkmst.model.Order; import io.swagger.annotations.*; import org.springframework.http.ResponseEntity; -import org.springframework.web.bind.annotation.PathVariable; -import org.springframework.web.bind.annotation.RequestBody; -import org.springframework.web.bind.annotation.RequestHeader; -import org.springframework.web.bind.annotation.RequestMapping; -import org.springframework.web.bind.annotation.RequestMethod; -import org.springframework.web.bind.annotation.RequestParam; -import org.springframework.web.bind.annotation.RequestPart; +import org.springframework.web.bind.annotation.*; import org.springframework.web.multipart.MultipartFile; import java.io.IOException; @@ -34,8 +28,9 @@ public interface StoreApi { @ApiResponses(value = { @ApiResponse(code = 400, message = "Invalid ID supplied"), @ApiResponse(code = 404, message = "Order not found") }) - @RequestMapping(value = "/store/order/{orderId}", - method = RequestMethod.DELETE) + @DeleteMapping( + value = "/store/order/{orderId}" + ) ResponseEntity deleteOrder(@ApiParam(value = "ID of the order that needs to be deleted",required=true ) @PathVariable("orderId") String orderId, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -44,9 +39,10 @@ public interface StoreApi { }, tags={ "store", }) @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation", response = Map.class, responseContainer = "Map") }) - @RequestMapping(value = "/store/inventory", - produces = { "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/store/inventory", + produces = { "application/json" } + ) ResponseEntity> getInventory( @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -55,9 +51,10 @@ public interface StoreApi { @ApiResponse(code = 200, message = "successful operation", response = Order.class), @ApiResponse(code = 400, message = "Invalid ID supplied"), @ApiResponse(code = 404, message = "Order not found") }) - @RequestMapping(value = "/store/order/{orderId}", - produces = { "application/xml", "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/store/order/{orderId}", + produces = { "application/xml", "application/json" } + ) ResponseEntity getOrderById(@ApiParam(value = "ID of pet that needs to be fetched",required=true ) @PathVariable("orderId") Long orderId, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -65,9 +62,10 @@ public interface StoreApi { @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation", response = Order.class), @ApiResponse(code = 400, message = "Invalid Order") }) - @RequestMapping(value = "/store/order", - produces = { "application/xml", "application/json" }, - method = RequestMethod.POST) + @PostMapping( + value = "/store/order", + produces = { "application/xml", "application/json" } + ) ResponseEntity placeOrder(@ApiParam(value = "order placed for purchasing the pet" ,required=true ) @RequestBody Order body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; } diff --git a/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/UserApi.java b/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/UserApi.java index bbabfd7b386..759bac9b3d8 100644 --- a/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/UserApi.java +++ b/samples/server/petstore/java-pkmst/src/main/java/com/prokarma/pkmst/controller/UserApi.java @@ -10,13 +10,7 @@ import com.prokarma.pkmst.model.User; import io.swagger.annotations.*; import org.springframework.http.ResponseEntity; -import org.springframework.web.bind.annotation.PathVariable; -import org.springframework.web.bind.annotation.RequestBody; -import org.springframework.web.bind.annotation.RequestHeader; -import org.springframework.web.bind.annotation.RequestMapping; -import org.springframework.web.bind.annotation.RequestMethod; -import org.springframework.web.bind.annotation.RequestParam; -import org.springframework.web.bind.annotation.RequestPart; +import org.springframework.web.bind.annotation.*; import org.springframework.web.multipart.MultipartFile; import java.io.IOException; @@ -33,24 +27,27 @@ public interface UserApi { @ApiOperation(value = "Create user", notes = "This can only be done by the logged in user.", response = Void.class, tags={ "user", }) @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation") }) - @RequestMapping(value = "/user", - method = RequestMethod.POST) + @PostMapping( + value = "/user" + ) ResponseEntity createUser(@ApiParam(value = "Created user object" ,required=true ) @RequestBody User body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @ApiOperation(value = "Creates list of users with given input array", notes = "", response = Void.class, tags={ "user", }) @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation") }) - @RequestMapping(value = "/user/createWithArray", - method = RequestMethod.POST) + @PostMapping( + value = "/user/createWithArray" + ) ResponseEntity createUsersWithArrayInput(@ApiParam(value = "List of user object" ,required=true ) @RequestBody List body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @ApiOperation(value = "Creates list of users with given input array", notes = "", response = Void.class, tags={ "user", }) @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation") }) - @RequestMapping(value = "/user/createWithList", - method = RequestMethod.POST) + @PostMapping( + value = "/user/createWithList" + ) ResponseEntity createUsersWithListInput(@ApiParam(value = "List of user object" ,required=true ) @RequestBody List body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -58,8 +55,9 @@ public interface UserApi { @ApiResponses(value = { @ApiResponse(code = 400, message = "Invalid username supplied"), @ApiResponse(code = 404, message = "User not found") }) - @RequestMapping(value = "/user/{username}", - method = RequestMethod.DELETE) + @DeleteMapping( + value = "/user/{username}" + ) ResponseEntity deleteUser(@ApiParam(value = "The name that needs to be deleted",required=true ) @PathVariable("username") String username, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -68,9 +66,10 @@ public interface UserApi { @ApiResponse(code = 200, message = "successful operation", response = User.class), @ApiResponse(code = 400, message = "Invalid username supplied"), @ApiResponse(code = 404, message = "User not found") }) - @RequestMapping(value = "/user/{username}", - produces = { "application/xml", "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/user/{username}", + produces = { "application/xml", "application/json" } + ) ResponseEntity getUserByName(@ApiParam(value = "The name that needs to be fetched. Use user1 for testing.",required=true ) @PathVariable("username") String username, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -78,17 +77,19 @@ public interface UserApi { @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation", response = String.class), @ApiResponse(code = 400, message = "Invalid username/password supplied") }) - @RequestMapping(value = "/user/login", - produces = { "application/xml", "application/json" }, - method = RequestMethod.GET) + @GetMapping( + value = "/user/login", + produces = { "application/xml", "application/json" } + ) ResponseEntity loginUser(@ApiParam(value = "The user name for login", required = true) @RequestParam(value = "username", required = true) String username,@ApiParam(value = "The password for login in clear text", required = true) @RequestParam(value = "password", required = true) String password, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @ApiOperation(value = "Logs out current logged in user session", notes = "", response = Void.class, tags={ "user", }) @ApiResponses(value = { @ApiResponse(code = 200, message = "successful operation") }) - @RequestMapping(value = "/user/logout", - method = RequestMethod.GET) + @GetMapping( + value = "/user/logout" + ) ResponseEntity logoutUser( @RequestHeader(value = "Accept", required = false) String accept) throws Exception; @@ -96,8 +97,9 @@ public interface UserApi { @ApiResponses(value = { @ApiResponse(code = 400, message = "Invalid user supplied"), @ApiResponse(code = 404, message = "User not found") }) - @RequestMapping(value = "/user/{username}", - method = RequestMethod.PUT) + @PutMapping( + value = "/user/{username}" + ) ResponseEntity updateUser(@ApiParam(value = "name that need to be deleted",required=true ) @PathVariable("username") String username,@ApiParam(value = "Updated user object" ,required=true ) @RequestBody User body, @RequestHeader(value = "Accept", required = false) String accept) throws Exception; } diff --git a/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/PetApiTest.java b/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/PetApiTest.java index cabc4d78e85..df1d4eb7f49 100644 --- a/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/PetApiTest.java +++ b/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/PetApiTest.java @@ -1,12 +1,12 @@ /* - * Swagger Petstore - * This is a sample server Petstore server. You can find out more about Swagger at [http://swagger.io](http://swagger.io) or on [irc.freenode.net, #swagger](http://swagger.io/irc/). For this sample, you can use the api key `special-key` to test the authorization filters. + * OpenAPI Petstore + * This is a sample server Petstore server. For this sample, you can use the api key `special-key` to test the authorization filters. * - * OpenAPI spec version: 1.0.0 - * Contact: apiteam@swagger.io + * The version of the OpenAPI document: 1.0.0 + * * - * NOTE: This class is auto generated by the swagger code generator program. - * https://github.com/swagger-api/swagger-codegen.git + * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). + * https://openapi-generator.tech * Do not edit the class manually. */ @@ -51,8 +51,8 @@ public class PetApiTest { */ @Test public void addPetTest() throws Exception { - Pet pet = null; - ResponseEntity response = api.addPet(pet , accept); + Pet body = null; + ResponseEntity response = api.addPet(body , accept); // TODO: test validations } @@ -69,7 +69,7 @@ public class PetApiTest { public void deletePetTest() throws Exception { Long petId = null; String apiKey = null; - ResponseEntity response = api.deletePet(petId, apiKey , accept); + ResponseEntity response = api.deletePet(petId, apiKey , accept); // TODO: test validations } @@ -85,7 +85,7 @@ public class PetApiTest { @Test public void findPetsByStatusTest() throws Exception { List status = null; - ResponseEntity> response = api.findPetsByStatus(status , accept); + ResponseEntity> response = api.findPetsByStatus(status , accept); // TODO: test validations } @@ -101,7 +101,7 @@ public class PetApiTest { @Test public void findPetsByTagsTest() throws Exception { List tags = null; - ResponseEntity> response = api.findPetsByTags(tags , accept); + ResponseEntity> response = api.findPetsByTags(tags , accept); // TODO: test validations } @@ -117,7 +117,7 @@ public class PetApiTest { @Test public void getPetByIdTest() throws Exception { Long petId = null; - ResponseEntity response = api.getPetById(petId , accept); + ResponseEntity response = api.getPetById(petId , accept); // TODO: test validations } @@ -132,8 +132,8 @@ public class PetApiTest { */ @Test public void updatePetTest() throws Exception { - Pet pet = null; - ResponseEntity response = api.updatePet(pet , accept); + Pet body = null; + ResponseEntity response = api.updatePet(body , accept); // TODO: test validations } @@ -151,7 +151,7 @@ public class PetApiTest { Long petId = null; String name = null; String status = null; - ResponseEntity response = api.updatePetWithForm(petId, name, status , accept); + ResponseEntity response = api.updatePetWithForm(petId, name, status , accept); // TODO: test validations } @@ -169,7 +169,7 @@ public class PetApiTest { Long petId = null; String additionalMetadata = null; MultipartFile file = null; - ResponseEntity response = api.uploadFile(petId, additionalMetadata, file , accept); + ResponseEntity response = api.uploadFile(petId, additionalMetadata, file , accept); // TODO: test validations } diff --git a/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/StoreApiTest.java b/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/StoreApiTest.java index 2247dfca592..92321171214 100644 --- a/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/StoreApiTest.java +++ b/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/StoreApiTest.java @@ -1,12 +1,12 @@ /* - * Swagger Petstore - * This is a sample server Petstore server. You can find out more about Swagger at [http://swagger.io](http://swagger.io) or on [irc.freenode.net, #swagger](http://swagger.io/irc/). For this sample, you can use the api key `special-key` to test the authorization filters. + * OpenAPI Petstore + * This is a sample server Petstore server. For this sample, you can use the api key `special-key` to test the authorization filters. * - * OpenAPI spec version: 1.0.0 - * Contact: apiteam@swagger.io + * The version of the OpenAPI document: 1.0.0 + * * - * NOTE: This class is auto generated by the swagger code generator program. - * https://github.com/swagger-api/swagger-codegen.git + * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). + * https://openapi-generator.tech * Do not edit the class manually. */ @@ -97,8 +97,8 @@ public class StoreApiTest { */ @Test public void placeOrderTest() throws Exception { - Order order = null; - ResponseEntity response = api.placeOrder(order , accept); + Order body = null; + ResponseEntity response = api.placeOrder(body , accept); // TODO: test validations } diff --git a/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/UserApiTest.java b/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/UserApiTest.java index b2ec4cec2ff..976f81a114e 100644 --- a/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/UserApiTest.java +++ b/samples/server/petstore/java-pkmst/src/test/java/com/prokarma/pkmst/controller/UserApiTest.java @@ -1,12 +1,12 @@ /* - * Swagger Petstore - * This is a sample server Petstore server. You can find out more about Swagger at [http://swagger.io](http://swagger.io) or on [irc.freenode.net, #swagger](http://swagger.io/irc/). For this sample, you can use the api key `special-key` to test the authorization filters. + * OpenAPI Petstore + * This is a sample server Petstore server. For this sample, you can use the api key `special-key` to test the authorization filters. * - * OpenAPI spec version: 1.0.0 - * Contact: apiteam@swagger.io + * The version of the OpenAPI document: 1.0.0 + * * - * NOTE: This class is auto generated by the swagger code generator program. - * https://github.com/swagger-api/swagger-codegen.git + * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). + * https://openapi-generator.tech * Do not edit the class manually. */ @@ -50,8 +50,8 @@ public class UserApiTest { */ @Test public void createUserTest() throws Exception { - User user = null; - ResponseEntity response = api.createUser(user , accept); + User body = null; + ResponseEntity response = api.createUser(body , accept); // TODO: test validations } @@ -66,8 +66,8 @@ public class UserApiTest { */ @Test public void createUsersWithArrayInputTest() throws Exception { - List user = null; - ResponseEntity response = api.createUsersWithArrayInput(user , accept); + List body = null; + ResponseEntity response = api.createUsersWithArrayInput(body , accept); // TODO: test validations } @@ -82,8 +82,8 @@ public class UserApiTest { */ @Test public void createUsersWithListInputTest() throws Exception { - List user = null; - ResponseEntity response = api.createUsersWithListInput(user , accept); + List body = null; + ResponseEntity response = api.createUsersWithListInput(body , accept); // TODO: test validations } @@ -163,8 +163,8 @@ public class UserApiTest { @Test public void updateUserTest() throws Exception { String username = null; - User user = null; - ResponseEntity response = api.updateUser(username, user , accept); + User body = null; + ResponseEntity response = api.updateUser(username, body , accept); // TODO: test validations }