From 1531ad48d0f5ed03036d5253e60cd5077d0d90ad Mon Sep 17 00:00:00 2001 From: Daniel Lange <60003126+dlange-hima@users.noreply.github.com> Date: Thu, 13 Jul 2023 03:55:14 +0200 Subject: [PATCH] Fixed problem with non-ref-enums which were handled like ref-enums (#16050) * #15476 Fixed problem with non-ref-enums which were handled like ref-enums * Adjusted test expectation --- .../src/main/java/org/openapitools/codegen/DefaultCodegen.java | 2 +- .../test/java/org/openapitools/codegen/DefaultCodegenTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java index e1bdaf6ca3b..f6871f94552 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java @@ -3950,7 +3950,7 @@ public class DefaultCodegen implements CodegenConfig { Schema referencedSchema = ModelUtils.getReferencedSchema(this.openAPI, p); //Referenced enum case: - if (referencedSchema.getEnum() != null && !referencedSchema.getEnum().isEmpty()) { + if (referencedSchema != p && referencedSchema.getEnum() != null && !referencedSchema.getEnum().isEmpty()) { List _enum = referencedSchema.getEnum(); property.isEnumRef = true; diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java index 5d79286bbc0..0c907854940 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java +++ b/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java @@ -4716,7 +4716,7 @@ public class DefaultCodegenTest { Assert.assertEquals(inlineEnumSchemaProperty.getName(), "enumType"); Assert.assertTrue(inlineEnumSchemaProperty.isEnum); Assert.assertTrue(inlineEnumSchemaProperty.isInnerEnum); - Assert.assertTrue(inlineEnumSchemaProperty.isEnumRef); + Assert.assertFalse(inlineEnumSchemaProperty.isEnumRef); Assert.assertTrue(inlineEnumSchemaProperty.getIsEnumOrRef()); Assert.assertTrue(inlineEnumSchemaProperty.isString); Assert.assertFalse(inlineEnumSchemaProperty.isContainer);