From 125e6a439b73fa79a96ed18623f5a20770f5449a Mon Sep 17 00:00:00 2001
From: William Cheng <wing328hk@gmail.com>
Date: Sun, 28 Feb 2021 22:38:50 +0800
Subject: [PATCH] better code, update sample for erlang client gen (#8853)

---
 .../languages/ErlangClientCodegen.java        | 19 ++++++++++++++-----
 .../erlang-client/.openapi-generator/VERSION  |  2 +-
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ErlangClientCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ErlangClientCodegen.java
index 65f92e33ac7..00013976a9b 100644
--- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ErlangClientCodegen.java
+++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ErlangClientCodegen.java
@@ -298,7 +298,7 @@ public class ErlangClientCodegen extends DefaultCodegen implements CodegenConfig
 
     @Override
     public String toOperationId(String operationId) {
-        // method name cannot use reserved keyword, e.g. return
+        // method name cannot use reserved keyword, e.g. if
         if (isReservedWord(operationId)) {
             LOGGER.warn(operationId + " (reserved word) cannot be used as method name. Renamed to " + underscore(sanitizeName("call_" + operationId)).replaceAll("\\.", "_"));
             operationId = "call_" + operationId;
@@ -352,24 +352,33 @@ public class ErlangClientCodegen extends DefaultCodegen implements CodegenConfig
         this.packageVersion = packageVersion;
     }
 
+    /**
+     * Returns the number of required parameters plus 1.
+     *
+     * @param os List of Codegen Parameters
+     * @return the string representation of the number of required paramters plus 1
+     */
     String length(Object os) {
         int l = 1;
         for (CodegenParameter o : ((ExtendedCodegenOperation) os).allParams) {
-            CodegenParameter q = o;
-            if (q.required)
+            if (o.required)
                 l++;
         }
-
         return Integer.toString(l);
     }
 
+    /**
+     * Returns the number of required parameters or body parameters.
+     *
+     * @param os List of Codegen Parameters
+     * @return the number of required paramters or body parameters
+     */
     int lengthRequired(List<CodegenParameter> allParams) {
         int l = 0;
         for (CodegenParameter o : allParams) {
             if (o.required || o.isBodyParam)
                 l++;
         }
-
         return l;
     }
 
diff --git a/samples/client/petstore/erlang-client/.openapi-generator/VERSION b/samples/client/petstore/erlang-client/.openapi-generator/VERSION
index d99e7162d01..c30f0ec2be7 100644
--- a/samples/client/petstore/erlang-client/.openapi-generator/VERSION
+++ b/samples/client/petstore/erlang-client/.openapi-generator/VERSION
@@ -1 +1 @@
-5.0.0-SNAPSHOT
\ No newline at end of file
+5.1.0-SNAPSHOT
\ No newline at end of file