Fix ObjectSerializer::isEmptyValue to not consider "0" as "" (#19472)

modules/openapi-generator/src/main/resources/php-nextgen/ObjectSerializer.mustache

@@ -188,6 +188,9 @@ class ObjectSerializer
             # For boolean values, '' is considered empty
             'bool','boolean' => !in_array($value, [false, 0], true),
 
+            # For string values, '' is considered empty.
+            'string' => $value === '',
+
             # For all the other types, any value at this point can be considered empty.
             default => true
         };

modules/openapi-generator/src/main/resources/php/ObjectSerializer.mustache

@@ -185,6 +185,10 @@ class ObjectSerializer
             case 'boolean':
                 return !in_array($value, [false, 0], true);
 
+            # For string values, '' is considered empty.
+            case 'string':
+                return $value === '';
+
             # For all the other types, any value at this point can be considered empty.
             default:
                 return true;

samples/client/echo_api/php-nextgen-streaming/src/ObjectSerializer.php

@@ -198,6 +198,9 @@ class ObjectSerializer
             # For boolean values, '' is considered empty
             'bool','boolean' => !in_array($value, [false, 0], true),
 
+            # For string values, '' is considered empty.
+            'string' => $value === '',
+
             # For all the other types, any value at this point can be considered empty.
             default => true
         };

samples/client/echo_api/php-nextgen/src/ObjectSerializer.php

@@ -198,6 +198,9 @@ class ObjectSerializer
             # For boolean values, '' is considered empty
             'bool','boolean' => !in_array($value, [false, 0], true),
 
+            # For string values, '' is considered empty.
+            'string' => $value === '',
+
             # For all the other types, any value at this point can be considered empty.
             default => true
         };

samples/client/petstore/php-nextgen/OpenAPIClient-php/src/ObjectSerializer.php

@@ -197,6 +197,9 @@ class ObjectSerializer
             # For boolean values, '' is considered empty
             'bool','boolean' => !in_array($value, [false, 0], true),
 
+            # For string values, '' is considered empty.
+            'string' => $value === '',
+
             # For all the other types, any value at this point can be considered empty.
             default => true
         };

samples/client/petstore/php/OpenAPIClient-php/lib/ObjectSerializer.php

@@ -194,6 +194,10 @@ class ObjectSerializer
             case 'boolean':
                 return !in_array($value, [false, 0], true);
 
+            # For string values, '' is considered empty.
+            case 'string':
+                return $value === '';
+
             # For all the other types, any value at this point can be considered empty.
             default:
                 return true;

samples/client/petstore/php/OpenAPIClient-php/tests/ObjectSerializerTest.php

@@ -430,6 +430,9 @@ class ObjectSerializerTest extends TestCase
             'form 0 bool, explode on, required false' => [
                 0, 'field', 'bool', 'form', true, false, 'field=0',
             ],
+            'form string "0", explode on, required true' => [
+                '0', 'field', 'string', 'form', true, true, 'field=0',
+            ],
         ];
     }
 

samples/client/petstore/php/psr-18/lib/ObjectSerializer.php

@@ -194,6 +194,10 @@ class ObjectSerializer
             case 'boolean':
                 return !in_array($value, [false, 0], true);
 
+            # For string values, '' is considered empty.
+            case 'string':
+                return $value === '';
+
             # For all the other types, any value at this point can be considered empty.
             default:
                 return true;