From 055605b075d5e03fefd8d514e3762741d2cb98bf Mon Sep 17 00:00:00 2001 From: Blake Lassiter Date: Sun, 9 Feb 2025 05:55:41 -0800 Subject: [PATCH] SortModelPropertiesByRequiredFlag - simplified comparison to order boolean false first (#20602) --- .../java/org/openapitools/codegen/DefaultCodegen.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java index 637b8efe203..33a9f15dad0 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java @@ -3190,14 +3190,7 @@ public class DefaultCodegen implements CodegenConfig { } protected void SortModelPropertiesByRequiredFlag(CodegenModel model) { - Comparator comparator = new Comparator() { - @Override - public int compare(CodegenProperty one, CodegenProperty another) { - if (one.required == another.required) return 0; - else if (one.required) return -1; - else return 1; - } - }; + Comparator comparator = Comparator.comparing(prop -> !prop.required); Collections.sort(model.vars, comparator); Collections.sort(model.allVars, comparator); }