mirror of
https://github.com/OpenAPITools/openapi-generator.git
synced 2026-03-20 17:49:07 +00:00
bdd34a34e9
bin/elm-petstore-all.sh invokes elm-petstore.sh and elm-0.18-petstore.sh. Both of these define `ELM_POST_PROCESS_FILE` for post-processing the generated files. If a user doesn't have elm-format installed, they may not realize that ensure-up-to-date has failed which causes CI to fail due to differences in the ELM generated outputs. This confusion can lead to a lot of downtime for contributors. For example, I encountered this while adding feature set information to all generators. I thought I had introduced the error and spent too long looking through my changeset and re-running `ensure-up-to-date` in the background before noticing the failed output. I was able to generate proper output by installing elm-format. With 80+ languages/frameworks and a rule for contributors to unblock CI by re-generating any failed samples, it's not feasible (in some cases, not possible) to ask contributors to install tooling specific post-processors. We'll have to rely on elm contributors to run the script manually. Ideally, elm generator templates should be updated to have properly formatted outputs as a default. We may want to consider documenting standards of what we put in the scripts under bin/*sh and bin/utils/ensure-up-to-date, one of those standards being that we omit toolchain specific post-processors.