loafle/openapi-generator-original
3
0
Fork 1
mirror of https://github.com/OpenAPITools/openapi-generator.git synced 2025-07-03 06:00:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PHP] Handle empty array response correct

Browse Source
This commit is contained in:
Arne Jørgensen 2016-06-13 23:07:45 +02:00
parent 871d5ddc5d
commit f5f4adac29
2 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/swagger-codegen/src/main/resources/php/api.mustache
View File

@ -244,11 +244,8 @@ use \{{invokerPackage}}\ObjectSerializer;
$headerParams{{#returnType}},
'{{returnType}}'{{/returnType}}
);
{{#returnType}}
if (!$response) {
return array(null, $statusCode, $httpHeader);
}
{{#returnType}}
return array($this->apiClient->getSerializer()->deserialize($response, '{{returnType}}', $httpHeader{{#discriminator}}, '{{discriminator}}'{{/discriminator}}), $statusCode, $httpHeader);
{{/returnType}}
{{^returnType}}

26
samples/client/petstore/php/SwaggerClient-php/tests/StoreApiTest.php
View File

@ -66,4 +66,30 @@ class StoreApiTest extends \PHPUnit_Framework_TestCase
$this->assertInternalType("int", $get_response['available']);
}
*/
/**
* test empty array response
*
* Make sure empty arrays from a producer is actually returned as
* an empty array and not some other value. At some point it was
* returned as null because the code stumbled on PHP loose type
* checking (not on empty array is true, same thing could happen
* with careless use of empty()).
*/
public function testEmptyArrayResponse()
{
// initialize the API client
$config = (new Configuration())->setHost('http://petstore.swagger.io/v2');
$apiClient = new ApiClient($config);
$storeApi = new Api\PetApi($apiClient);
// this call returns and empty array
$response = $storeApi->findPetsByStatus(array());
// make sure this is an array as we want it to be
$this->assertInternalType("array", $response);
// make sure the array is empty just in case the petstore
// server changes its output
$this->assertEmpty($response);
}
}