loafle/openapi-generator-original
3
0
Fork 1
mirror of https://github.com/OpenAPITools/openapi-generator.git synced 2025-07-04 14:40:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

List/Map emptiness checking and stream variation (#11920)

Browse Source 
I have changed the way to check for empty maps and lists, instead of checking if the size is greater than 0, It is more understandable and faster using !x.isEmpty() method. Also, instead of using stream().filter().findFirst().isPresent(), it is recomendable using its equivalent stream().anyMatch() which as well makes it easier to understand and efficient.
This commit is contained in:
Rafael González Castillero 2022-03-21 16:30:43 +01:00 committed by GitHub
parent 0a48976ccb
commit e159919ba5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenOperation.java
View File

@ -68,11 +68,11 @@ public class CodegenOperation {
* @return true if parameter exists, false otherwise * @return true if parameter exists, false otherwise
*/ */
private static boolean nonEmpty(List<?> params) { private static boolean nonEmpty(List<?> params) {
return params != null && params.size() > 0; return params != null && !params.isEmpty();
} }
private static boolean nonEmpty(Map<?, ?> params) { private static boolean nonEmpty(Map<?, ?> params) {
return params != null && params.size() > 0; return params != null && !params.isEmpty();
} }
/** /**
@ -189,7 +189,7 @@ public class CodegenOperation {
* @return true if responses contain a default response, false otherwise * @return true if responses contain a default response, false otherwise
*/ */
public boolean getHasDefaultResponse() { public boolean getHasDefaultResponse() {
return responses.stream().filter(response -> response.isDefault).findFirst().isPresent(); return responses.stream().anyMatch(response -> response.isDefault);
} }
/** /**