diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9309b70418a..3183e70b570 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,7 +31,7 @@ For a list of variables available in the template, please refer to this [page](h Code change should conform to the programming style guide of the respective langauages: - C#: https://msdn.microsoft.com/en-us/library/vstudio/ff926074.aspx - Java: https://google.github.io/styleguide/javaguide.html -- JavaScript - https://github.com/airbnb/javascript +- JavaScript - https://github.com/airbnb/javascript/tree/master/es5 - ObjC: https://github.com/NYTimes/objective-c-style-guide - PHP: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md - Python: https://www.python.org/dev/peps/pep-0008/ diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java index f9bd468a25b..0415cfb5975 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java @@ -624,41 +624,7 @@ public class DefaultCodegen { * @return string presentation of the default value of the property */ public String toDefaultValueWithParam(String name, Property p) { - if (p instanceof StringProperty) { - return " = data." + name + ";"; - } else if (p instanceof BooleanProperty) { - return " = data." + name + ";"; - } else if (p instanceof DateProperty) { - return " = data." + name + ";"; - } else if (p instanceof DateTimeProperty) { - return " = data." + name + ";"; - } else if (p instanceof DoubleProperty) { - DoubleProperty dp = (DoubleProperty) p; - if (dp.getDefault() != null) { - return dp.getDefault().toString(); - } - return " = data." + name + ";"; - } else if (p instanceof FloatProperty) { - FloatProperty dp = (FloatProperty) p; - if (dp.getDefault() != null) { - return dp.getDefault().toString(); - } - return " = data." + name + ";"; - } else if (p instanceof IntegerProperty) { - IntegerProperty dp = (IntegerProperty) p; - if (dp.getDefault() != null) { - return dp.getDefault().toString(); - } - return " = data." + name + ";"; - } else if (p instanceof LongProperty) { - LongProperty dp = (LongProperty) p; - if (dp.getDefault() != null) { - return dp.getDefault().toString(); - } - return " = data." + name + ";"; - } else { - return " = data." + name + ";"; - } + return " = data." + name + ";"; } /** diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavascriptClientCodegen.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavascriptClientCodegen.java index fbf8b1adae5..27aad0ebbff 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavascriptClientCodegen.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavascriptClientCodegen.java @@ -279,7 +279,7 @@ public class JavascriptClientCodegen extends DefaultCodegen implements CodegenCo @Override public String toModelImport(String name) { - return name; + return toModelName(name); } @Override @@ -308,43 +308,24 @@ public class JavascriptClientCodegen extends DefaultCodegen implements CodegenCo return "[]"; } else if (p instanceof MapProperty) { return "{}"; - } else if (p instanceof LongProperty) { - LongProperty dp = (LongProperty) p; - if (dp.getDefault() != null) { - return dp.getDefault().toString()+"l"; - } - return "null"; - - // added for Javascript } else if (p instanceof RefProperty) { RefProperty rp = (RefProperty)p; - return "new " +rp.getSimpleRef() + "()"; + return "new " + getTypeDeclaration(p) + "()"; } return super.toDefaultValue(p); } - @Override public String toDefaultValueWithParam(String name, Property p) { - if (p instanceof ArrayProperty) { - return " = new Array();"; - } else if (p instanceof MapProperty) { - return " = {}"; - } else if (p instanceof LongProperty) { - LongProperty dp = (LongProperty) p; - return " = data." + name + ";"; - - // added for Javascript - } else if (p instanceof RefProperty) { - RefProperty rp = (RefProperty)p; + if (p instanceof RefProperty) { + RefProperty rp = (RefProperty) p; return ".constructFromObject(data." + name + ");"; } return super.toDefaultValueWithParam(name, p); } - @Override public String getSwaggerType(Property p) { String swaggerType = super.getSwaggerType(p); diff --git a/samples/client/petstore/javascript/src/model/Pet.js b/samples/client/petstore/javascript/src/model/Pet.js index 88674c64bc9..392007d6a54 100644 --- a/samples/client/petstore/javascript/src/model/Pet.js +++ b/samples/client/petstore/javascript/src/model/Pet.js @@ -95,9 +95,9 @@ var StatusEnum = function StatusEnum() { self.name = data.name; - self.photoUrls = new Array(); + self.photoUrls = data.photoUrls; - self.tags = new Array(); + self.tags = data.tags; self.status = data.status; diff --git a/samples/client/petstore/javascript/test/api/PetApiTest.js b/samples/client/petstore/javascript/test/api/PetApiTest.js index f2c72bb8011..9385cf2701b 100644 --- a/samples/client/petstore/javascript/test/api/PetApiTest.js +++ b/samples/client/petstore/javascript/test/api/PetApiTest.js @@ -40,6 +40,7 @@ describe('PetApi', function() { expect(fetched).to.be.ok(); expect(fetched.id).to.be(pet.id); + expect(fetched.getPhotoUrls()).to.eql(pet.getPhotoUrls()); expect(fetched.getCategory()).to.be.ok(); expect(fetched.getCategory().getName()).to.be(pet.getCategory().getName());