From 81e9bd0d738969a23b0d2945a27ce6ca76151246 Mon Sep 17 00:00:00 2001 From: wing328 Date: Sat, 10 Sep 2016 00:23:00 +0800 Subject: [PATCH] add tips for filing better PR --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2551c58bc6d..e22da10e35b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -72,3 +72,4 @@ To start the CI tests, you can run `mvn verify -Psamples` (assuming you've all t - Add test case(s) to cover the change - Document the fix in the code to make the code more readable - Make sure test cases passed after the change (one way is to leverage https://travis-ci.org/ to run the CI tests) +- File a PR with meaningful title, description and commit messages. A good example is https://github.com/swagger-api/swagger-codegen/pull/3306