loafle/openapi-generator-original
3
0
Fork 1
mirror of https://github.com/OpenAPITools/openapi-generator.git synced 2025-05-12 12:40:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[php-flight] fix: use static PHPUnit assertions (#21253)

Browse Source 
Static analysis tools such as PHPStan report errors when dynamic calls are used
for static methods.

```
ERROR Dynamic call to static method PHPUnit\Framework\Assert::assertEquals().
```

According to the source code of PHPUnit
(https://github.com/sebastianbergmann/phpunit/blob/9.5.0/src/Framework/Assert.php)
the function is indeed static.

```php
public static function assertTrue($condition, string $message = ''): void
```

This change updates to PHP Flight test template `register_routes_test.mustache`
to use static calls for PHPUnit assertions.
This commit is contained in:
Jonas Renggli 2025-05-11 16:22:34 +02:00 committed by GitHub
parent 66e8c932c3
commit 6344bfa779
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/openapi-generator/src/main/resources/php-flight/register_routes_test.mustache vendored
View File

@ -26,7 +26,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
{{/operations}}
};
\{{invokerPackage}}\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
{{/apis}}
{{#models}}
@ -41,7 +41,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
{{/-first}}
{{/enumVars}}
{{/allowableValues}}
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\{{escapedModelPackage}}\\{{classname}}'),
\{{modelPackage}}\{{classname}}::{{#allowableValues}}{{#enumVars}}{{#-first}}{{{name}}}{{/-first}}{{/enumVars}}{{/allowableValues}}
);

12
samples/server/petstore/php-flight/Test/RegisterRoutesTest.php
View File

@ -29,7 +29,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
}
};
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
public function testRegisterRoutesAbstractStoreApi(): void
{
@ -39,7 +39,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
}
};
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
public function testRegisterRoutesAbstractUserApi(): void
{
@ -49,12 +49,12 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
}
};
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
public function testParseParamsEnumFindPetsByStatusStatusParameterInner(): void
{
$value = 'available';
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\OpenAPIServer\\Model\\FindPetsByStatusStatusParameterInner'),
\OpenAPIServer\Model\FindPetsByStatusStatusParameterInner::AVAILABLE
);
@ -62,7 +62,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
public function testParseParamsEnumOrderStatus(): void
{
$value = 'placed';
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\OpenAPIServer\\Model\\OrderStatus'),
\OpenAPIServer\Model\OrderStatus::PLACED
);
@ -70,7 +70,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
public function testParseParamsEnumPetStatus(): void
{
$value = 'available';
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\OpenAPIServer\\Model\\PetStatus'),
\OpenAPIServer\Model\PetStatus::AVAILABLE
);