loafle/openapi-generator-original
3
0
Fork 1
mirror of https://github.com/OpenAPITools/openapi-generator.git synced 2025-12-11 12:02:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PHP] Non required enum property (#7723)

Browse Source 
* Add required enum property

* Update samples

* Add test case which reproduce the problem

refs https://github.com/swagger-api/swagger-codegen/pull/7686#issuecomment-368200011
> 2. Non-required enum property is listed as invalid when omitted

* If the property is not empty, perform validation

* Update samples

* Use is_null() according to setter implementation

refs 377247f125/modules/swagger-codegen/src/main/resources/php/model_generic.mustache (L347)

* Update samples
This commit is contained in:
Akihito Nakano
2018-03-08 22:54:34 +09:00
committed by William Cheng
parent 227e2458d4
commit 32cf2f16f5
8 changed files with 113 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
samples/client/petstore/php/SwaggerClient-php/tests/EnumTestTest.php
View File

@@ -15,4 +15,20 @@ class EnumTestTest extends \PHPUnit_Framework_TestCase
$this->assertSame(EnumTest::ENUM_NUMBER_1_DOT_1, 1.1);
$this->assertSame(EnumTest::ENUM_NUMBER_MINUS_1_DOT_2, -1.2);
}
public function testNonRequiredPropertyIsOptional()
{
$enum = new EnumTest([
'enum_string_required' => 'UPPER',
]);
$this->assertSame([], $enum->listInvalidProperties());
$this->assertTrue($enum->valid());
}
public function testRequiredProperty()
{
$enum = new EnumTest();
$this->assertSame(["'enum_string_required' can't be null"], $enum->listInvalidProperties());
$this->assertFalse($enum->valid());
}
}