diff --git a/modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskDslTest.kt b/modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskDslTest.kt index b2796f1da58..cf7e688c359 100644 --- a/modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskDslTest.kt +++ b/modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskDslTest.kt @@ -34,6 +34,7 @@ class GenerateTaskDslTest : TestBase() { @Test fun `openApiGenerate should create an expected file structure from URL config`() { val specUrl = "https://raw.githubusercontent.com/OpenAPITools/openapi-generator/b6b8c0db872fb4a418ae496e89c7e656e14be165/modules/openapi-generator-gradle-plugin/src/test/resources/specs/petstore-v3.0.yaml" + val urlParams ="?meaningless=params&so=it&results=in&illegal=filenames&on=windows" // Arrange val buildContents = """ plugins { @@ -41,7 +42,7 @@ class GenerateTaskDslTest : TestBase() { } openApiGenerate { generatorName = "kotlin" - remoteInputSpec = "$specUrl" + remoteInputSpec = "$specUrl$urlParams" outputDir = file("build/kotlin").absolutePath apiPackage = "org.openapitools.example.api" invokerPackage = "org.openapitools.example.invoker" diff --git a/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/CodeGenMojo.java b/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/CodeGenMojo.java index 55c6a7549bd..cae290151e5 100644 --- a/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/CodeGenMojo.java +++ b/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/CodeGenMojo.java @@ -1066,7 +1066,7 @@ public class CodeGenMojo extends AbstractMojo { String name = inputSpecFile.getName(); URL url = inputSpecRemoteUrl(); - if (inputSpecFile.exists() && url != null) { + if (url != null) { String[] segments = url.getPath().split("/"); name = Files.getNameWithoutExtension(segments[segments.length - 1]); } diff --git a/modules/openapi-generator-maven-plugin/src/test/java/org/openapitools/codegen/plugin/CodeGenMojoTest.java b/modules/openapi-generator-maven-plugin/src/test/java/org/openapitools/codegen/plugin/CodeGenMojoTest.java index 3ee158240d7..37940366fd3 100644 --- a/modules/openapi-generator-maven-plugin/src/test/java/org/openapitools/codegen/plugin/CodeGenMojoTest.java +++ b/modules/openapi-generator-maven-plugin/src/test/java/org/openapitools/codegen/plugin/CodeGenMojoTest.java @@ -68,6 +68,10 @@ public class CodeGenMojoTest extends BaseTestCase { testCommonConfiguration("jar"); } + public void testCommonConfigurationWithRemoteInputSpec() throws Exception { + testCommonConfiguration("remote"); + } + @SuppressWarnings("unchecked") private void testCommonConfiguration(String profile) throws Exception { CodeGenMojo mojo = loadMojo(newTempFolder(), "src/test/resources/default", profile); diff --git a/modules/openapi-generator-maven-plugin/src/test/resources/default/pom.xml b/modules/openapi-generator-maven-plugin/src/test/resources/default/pom.xml index 9ef40042d38..b1465ab0e3b 100644 --- a/modules/openapi-generator-maven-plugin/src/test/resources/default/pom.xml +++ b/modules/openapi-generator-maven-plugin/src/test/resources/default/pom.xml @@ -55,6 +55,12 @@ + + remote + + https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml?meaningless=params&so=it&results=in&illegal=filenames&on=windows + + common-maven