From 164f5bbb72a19cb730830030fb8f110cd5538e80 Mon Sep 17 00:00:00 2001 From: wing328 Date: Mon, 9 Oct 2017 09:28:31 +0800 Subject: [PATCH] fix underscore to handle spaces (#6637) --- .../main/java/io/swagger/codegen/DefaultCodegen.java | 2 ++ .../test/java/io/swagger/codegen/CodegenTest.java | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java index 39af1118cfc..2e8b0ebab5b 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java @@ -3035,6 +3035,8 @@ public class DefaultCodegen { word = word.replaceAll(firstPattern, replacementPattern); word = word.replaceAll(secondPattern, replacementPattern); word = word.replace('-', '_'); + // replace space with underscore + word = word.replace(' ', '_'); word = word.toLowerCase(); return word; } diff --git a/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java b/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java index 18acd4757a9..0fae4eac112 100644 --- a/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java +++ b/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java @@ -25,6 +25,18 @@ public class CodegenTest { Assert.assertEquals(codegen.sanitizeTag("1foo"), "Class1foo"); } + @Test(description = "test underscore") + public void underscoreNamesTest() { + final DefaultCodegen codegen = new DefaultCodegen(); + + Assert.assertEquals(codegen.underscore("foo"), "foo"); + Assert.assertEquals(codegen.underscore("foo-bar"), "foo_bar"); + Assert.assertEquals(codegen.underscore("foo bar"), "foo_bar"); + + Assert.assertEquals(codegen.underscore("FooBar"), "foo_bar"); + Assert.assertEquals(codegen.underscore("FooBarBaz"), "foo_bar_baz"); + } + @Test(description = "test camelize") public void camelizeNamesTest() { final DefaultCodegen codegen = new DefaultCodegen();