loafle/openapi-generator-original
3
0
Fork 1
mirror of https://github.com/OpenAPITools/openapi-generator.git synced 2025-07-03 22:20:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update TypeScript to do a better check for empty on basePath.

Browse Source 
In Angular if a value is not defined for injection it is passed as
undefined. That means that most of the time `if (value) {` is a
reasonable test. Unfortunately since `""` (empty string) is also falsey
by nature, an empty string will not trigger the if properly.

Instead you should check `if (value !== undefined) {`.
This commit is contained in:
Andrew Z Allen 2016-05-09 22:59:25 -06:00
parent e17710fc72
commit 0b8c936972
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/swagger-codegen/src/main/resources/typescript-angular/api.mustache
View File

@ -18,7 +18,7 @@ namespace {{package}} {
static $inject: string[] = ['$http', '$httpParamSerializer']; static $inject: string[] = ['$http', '$httpParamSerializer'];
constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) { constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) {
if (basePath) { if (basePath !== undefined) {
this.basePath = basePath; this.basePath = basePath;
} }
} }

2
samples/client/petstore/typescript-angular/API/Client/PetApi.ts
View File

@ -12,7 +12,7 @@ namespace API.Client {
static $inject: string[] = ['$http', '$httpParamSerializer']; static $inject: string[] = ['$http', '$httpParamSerializer'];
constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) { constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) {
if (basePath) { if (basePath !== undefined) {
this.basePath = basePath; this.basePath = basePath;
} }
} }

2
samples/client/petstore/typescript-angular/API/Client/StoreApi.ts
View File

@ -12,7 +12,7 @@ namespace API.Client {
static $inject: string[] = ['$http', '$httpParamSerializer']; static $inject: string[] = ['$http', '$httpParamSerializer'];
constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) { constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) {
if (basePath) { if (basePath !== undefined) {
this.basePath = basePath; this.basePath = basePath;
} }
} }

2
samples/client/petstore/typescript-angular/API/Client/UserApi.ts
View File

@ -12,7 +12,7 @@ namespace API.Client {
static $inject: string[] = ['$http', '$httpParamSerializer']; static $inject: string[] = ['$http', '$httpParamSerializer'];
constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) { constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) {
if (basePath) { if (basePath !== undefined) {
this.basePath = basePath; this.basePath = basePath;
} }
} }