This commit is contained in:
crusader 2018-05-27 16:05:54 +09:00
parent 769594fb9f
commit aad7abe211
2 changed files with 6 additions and 6 deletions

View File

@ -130,15 +130,15 @@ export abstract class RPCClient<T> {
this._pendingRequests.delete(id); this._pendingRequests.delete(id);
this._pendingRequestsCount--; this._pendingRequestsCount--;
if (undefined !== result) { if (undefined !== error) {
reqState.subject.next(result);
} else if (undefined !== error) {
const rpcClientError: RPCClientError = { const rpcClientError: RPCClientError = {
request: reqState.request, request: reqState.request,
response: error, response: error,
}; };
console.error(rpcClientError); console.error(rpcClientError);
reqState.subject.error(rpcClientError); reqState.subject.error(rpcClientError);
} else {
reqState.subject.next(result);
} }
} }

View File

@ -94,10 +94,10 @@ export class JSONRPCClientResponseCodec implements RPCClientResponseCodec {
} }
public isNotification(): boolean { public isNotification(): boolean {
if (undefined !== this.id() || undefined === this.result()) { if (undefined === this.id() && undefined !== this.result()) {
return false; return true;
} }
return true; return false;
} }
public notification(): RPCClientNotificationCodec | undefined { public notification(): RPCClientNotificationCodec | undefined {