ing

client/client.go

@@ -315,7 +315,7 @@ func (c *client) rpcWriter(stopChan <-chan struct{}, writerDone chan<- error) {
 			}
 
 			err = fmt.Errorf("Client: Cannot send request to wire: [%s]", err)
-			logging.Logger().Error(err.Error())
+			logging.Logger().Error(err)
 			continue
 		}
 	}
@@ -343,8 +343,7 @@ func (c *client) rpcReader(readerDone chan<- error) {
 				logging.Logger().Infof("Client: disconnected from server")
 				return
 			}
-			err = fmt.Errorf("Client: Cannot decode response or notify: [%s]", err)
-			logging.Logger().Error(err.Error())
+			logging.Logger().Errorf("Client: Cannot decode response or notify: [%s]", err)
 			continue
 		}
 

protocol/json/client_notification.go

@@ -26,6 +26,10 @@ type ClientNotificationCodec struct {
 	codec codec.Codec
 }
 
+func (cnc *ClientNotificationCodec) HasResponse() bool {
+	return false
+}
+
 func (cnc *ClientNotificationCodec) Method() string {
 	return cnc.noti.Method
 }

protocol/registry_codec.go

@@ -10,4 +10,6 @@ type RegistryCodec interface {
 	// Reads the request filling the RPC method args.
 	ReadParams(args []interface{}) error
 	Params() ([]string, error)
+
+	HasResponse() bool
 }

protocol/server_codec.go

@@ -15,7 +15,6 @@ type ServerCodec interface {
 type ServerRequestCodec interface {
 	RegistryCodec
 
-	HasResponse() bool
 	WriteResponse(w io.Writer, reply interface{}) error
 	WriteError(w io.Writer, status int, err error) error
 }