fb23c1750a
t.Parallel effectively fires off a goroutine, so we can't use the test range variable directly. That can result in different subtests using the same test case data, causing sporadic failures, or some test cases rarely being actually tested. This was uncovered while stress-testing the test suite for an unrelated refactor. While at it, one test case in TestMouseClickNode was incorrect. contextmenu fires on a right click, so ModifierNone won't fire it. This wasn't caught before, as this test case was almost never ran. After the data race fix, the test case failed consistently, before being fixed.
About chromedp 
Package chromedp is a faster, simpler way to drive browsers supporting the Chrome DevTools Protocol in Go using the without external dependencies (ie, Selenium, PhantomJS, etc).
Installing
Install in the usual Go way:
go get -u github.com/chromedp/chromedp
Examples
Please see the examples project for more examples. Please refer to the GoDoc API listing for a summary of the API and Actions.
Resources
- chromedp: A New Way to Drive the Web - GopherCon SG 2017 talk
- Chrome DevTools Protocol - Chrome DevTools Protocol Domain documentation
- chromedp examples - various
chromedpexamples github.com/chromedp/cdproto- GoDoc listing for the CDP domains used bychromedpgithub.com/chromedp/cdproto-gen- tool used to generatecdprotogithub.com/chromedp/chromedp-proxy- a simple CDP proxy for logging CDP clients and browsers
TODO
- Move timeouts to context (defaults)
- Implement more query selector options (allow over riding context timeouts)
- Contextual actions for "dry run" (or via an accumulator?)
- Network loader / manager
- Profiler