939d377090
It's Run that actually starts a Browser, not NewContext. If the browser is closed or crashes, the browser handler will fail to read from the websocket, and its goroutines will stop. However, the target handler's goroutines may not stop. The browser handler uses a separate cancel function to stop itself when encountering a websocket error, so that doesn't propagate to the original context children, like the target handler. To fix this, make it so that NewContext can keep the cancel function around, for Run to use it in this scenario. And add a test case that tests this very edge case, which used to time out before the fix. Fixes #289.
About chromedp 
Package chromedp is a faster, simpler way to drive browsers supporting the Chrome DevTools Protocol in Go using the without external dependencies (ie, Selenium, PhantomJS, etc).
Installing
Install in the usual Go way:
go get -u github.com/chromedp/chromedp
Examples
Please see the examples project for more examples. Please refer to the GoDoc API listing for a summary of the API and Actions.
Resources
- chromedp: A New Way to Drive the Web - GopherCon SG 2017 talk
- Chrome DevTools Protocol - Chrome DevTools Protocol Domain documentation
- chromedp examples - various
chromedpexamples github.com/chromedp/cdproto- GoDoc listing for the CDP domains used bychromedpgithub.com/chromedp/cdproto-gen- tool used to generatecdprotogithub.com/chromedp/chromedp-proxy- a simple CDP proxy for logging CDP clients and browsers
TODO
- Move timeouts to context (defaults)
- Implement more query selector options (allow over riding context timeouts)
- Contextual actions for "dry run" (or via an accumulator?)
- Network loader / manager
- Profiler