From a29b1ec1d641b549b23320b0732ba5cda624949f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Mon, 8 Apr 2019 12:38:36 +0200 Subject: [PATCH] deflake TestNavigate For some reason, this test fails about half the time on Travis, but I can't get it to fail even after stress-testing hundreds of concurrent runs. It might be because Travis is on a much older version of Chrome. We'll fix that soon, by having chromedp select a specific version of Chrome. For now, make it more conservative, not assuming that a Location after a Navigate isn't racy. --- nav_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nav_test.go b/nav_test.go index 13fd783..d3b9aa5 100644 --- a/nav_test.go +++ b/nav_test.go @@ -23,8 +23,8 @@ func TestNavigate(t *testing.T) { var urlstr string if err := Run(ctx, - Location(&urlstr), WaitVisible(`#icon-brankas`, ByID), + Location(&urlstr), ); err != nil { t.Fatal(err) }