test cancelling an entire Allocator directly

To ensure that it propagates to each browser correctly.
This commit is contained in:
Daniel Martí 2019-03-22 17:19:30 +00:00
parent a0a36956a8
commit 8ff2971fc5

View File

@ -9,8 +9,8 @@ import (
func TestExecAllocator(t *testing.T) { func TestExecAllocator(t *testing.T) {
t.Parallel() t.Parallel()
poolCtx, cancel := NewAllocator(context.Background(), WithExecAllocator(allocOpts...)) poolCtx, poolCancel := NewAllocator(context.Background(), WithExecAllocator(allocOpts...))
defer cancel() defer poolCancel()
// TODO: test that multiple child contexts are run in different // TODO: test that multiple child contexts are run in different
// processes and browsers. // processes and browsers.
@ -41,3 +41,30 @@ func TestExecAllocator(t *testing.T) {
} }
t.Fatalf("temporary user data dir %q not deleted", tempDir) t.Fatalf("temporary user data dir %q not deleted", tempDir)
} }
func TestExecAllocatorCancelParent(t *testing.T) {
t.Parallel()
poolCtx, poolCancel := NewAllocator(context.Background(), WithExecAllocator(allocOpts...))
defer poolCancel()
// TODO: test that multiple child contexts are run in different
// processes and browsers.
taskCtx, _ := NewContext(poolCtx)
if err := Run(taskCtx, Tasks{}); err != nil {
t.Fatal(err)
}
tempDir := FromContext(taskCtx).Browser.userDataDir
pool := FromContext(taskCtx).Allocator
// Canceling the pool context should stop all browsers too.
poolCancel()
pool.Wait()
if _, err := os.Lstat(tempDir); os.IsNotExist(err) {
return
}
t.Fatalf("temporary user data dir %q not deleted", tempDir)
}