commons_go/chromedp
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rewrite TestReload without a sleep

Browse Source
This commit is contained in:
Daniel Martí 2019-03-21 20:09:46 +00:00
parent f742f327a7
commit 2b925df0fb
2 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
nav_test.go
View File

@ -2,11 +2,13 @@ package chromedp
import ( import (
"bytes" "bytes"
"fmt"
"image" "image"
_ "image/png" _ "image/png"
"net/http"
"net/http/httptest"
"strings" "strings"
"testing" "testing"
"time"
"github.com/chromedp/cdproto/emulation" "github.com/chromedp/cdproto/emulation"
"github.com/chromedp/cdproto/page" "github.com/chromedp/cdproto/page"
@ -188,19 +190,33 @@ func TestStop(t *testing.T) {
func TestReload(t *testing.T) { func TestReload(t *testing.T) {
t.Parallel() t.Parallel()
ctx, cancel := testAllocate(t, "form.html") count := 0
// create test server
mux := http.NewServeMux()
mux.HandleFunc("/", func(res http.ResponseWriter, req *http.Request) {
fmt.Fprintf(res, `<html>
<head>
<title>Title</title>
</head>
<body>
<div id="count%d"></div>
</body></html`, count)
count++
})
s := httptest.NewServer(mux)
defer s.Close()
ctx, cancel := testAllocate(t, "")
defer cancel() defer cancel()
var title, exptitle string var title, exptitle string
if err := Run(ctx, Tasks{ if err := Run(ctx, Tasks{
WaitVisible(`#form`, ByID), // for form.html Navigate(s.URL),
WaitReady(`#count0`, ByID),
Title(&exptitle), Title(&exptitle),
Reload(), Reload(),
// TODO: rewrite test to change the content after a reload, so WaitReady(`#count1`, ByID),
// we can wait on a selector.
Sleep(10 * time.Millisecond),
WaitVisible(`#form`, ByID), // for form.html
Title(&title), Title(&title),
}); err != nil { }); err != nil {
t.Fatal(err) t.Fatal(err)

2
query_test.go
View File

@ -960,8 +960,6 @@ func TestFileUpload(t *testing.T) {
// parallel // parallel
//t.Parallel() //t.Parallel()
// TODO: check why moving the Navigate action below to
// testAllocate makes this test hang.
ctx, cancel := testAllocate(t, "") ctx, cancel := testAllocate(t, "")
defer cancel() defer cancel()