Fixes infinite loop (and consequentially spiked CPU usage) on ctx timeout

2017-06-22 13:27:36 +01:00 · 2017-06-22 13:27:36 +01:00 · 10a6f7bd20
commit 10a6f7bd20
parent 9282791225
1 changed files with 7 additions and 1 deletions
--- a/sel.go
+++ b/sel.go
@ -83,7 +83,13 @@ func (s *Selector) run(ctxt context.Context, h cdp.Handler) chan error {
 		for {
 			root, err := h.GetRoot(ctxt)
 			if err != nil {
-				continue
+				select {
+				case <-ctxt.Done():
+					ch <- ctxt.Err()
+					return
+				default:
+					continue
+				}
 			}

 			select {